Code Monkey home page Code Monkey logo

Comments (17)

recluze avatar recluze commented on May 26, 2024 1

These will only go in the assignment "download zip" ... don't need to have them come back ... but will need to have them extracted when running server-side tests (since the .py files might be needed) but we will have to take them from our server copy ... the only files that come from the student will be the "modifiable files"

from autograder.

recluze avatar recluze commented on May 26, 2024 1

Ah, right. Sorry. Was looking at the newer assignment (with no extra files).

from autograder.

soachishti avatar soachishti commented on May 26, 2024 1

It was deep :)

Resolved. 939a52e

I have connected save signal to sender "OtherFile". Each time a other file is saved, it is then added (appended or rewrite) to existing assignment zip file.

from autograder.

soachishti avatar soachishti commented on May 26, 2024 1

It won't generate the zip file each time. It will append the other_file to the zip file.

If assignment is saved first time:

  1. Assignment save signal generates the zip file.
  2. OtherFile save signal append "other file" to existing zip file.

If Assignment is updated:

  1. Assignment save signal generates the zip file (Including existing other files).
  2. OtherFile save signal is NOT called for existing files. It will be called for only new files.

from autograder.

recluze avatar recluze commented on May 26, 2024

(I'm currently assigning all issues to @soachishti but feel free to pass these on.)

from autograder.

soachishti avatar soachishti commented on May 26, 2024

I will look into that.

from autograder.

soachishti avatar soachishti commented on May 26, 2024

Other file functionality added. 0cf3da9 @recluze

from autograder.

recluze avatar recluze commented on May 26, 2024

ATM, they're not included in the .zip downloaded by the student. He will need them to complete the assignment.

from autograder.

soachishti avatar soachishti commented on May 26, 2024

They are included in student's .zip file and other files are copied to submission directory (from server-side copy) before running pytest.

from autograder.

recluze avatar recluze commented on May 26, 2024

Er ... actually .. just added another assignment with three files and they don't seem to show up in the .zip downloaded by student. Can you please confirm by adding another assignment?

from autograder.

soachishti avatar soachishti commented on May 26, 2024

It's working with me. Have you enable permission for yourself (User Permission). I have tested it with guru and nauman and it is working on both.

from autograder.

soachishti avatar soachishti commented on May 26, 2024

https://www.screencast.com/t/h49HRPE0DYpV

from autograder.

recluze avatar recluze commented on May 26, 2024

Well, it shows up fine in the backend (under Assignments) -- even after reload of the page. But when I download the assignment as a user, the assignment3.zip does not have the extra files. I just checked again with an older assignment. I will try again as I did get them downloaded in the first assignment once.

I'll update when I have more info inshaallah.

from autograder.

recluze avatar recluze commented on May 26, 2024

Just checked again. It shows up in the submission folder (as in your screenshot) but does not in the student's downloaded zip file.

from autograder.

soachishti avatar soachishti commented on May 26, 2024

Zip file is generated when Assignment save signal is called. If correct zip file is available in assignment folder then there should be no problem because zip file is downloaded from the same folder.

Can you check whether student panel and admin are on same ip/host. Last time I was updating Assignment on localhost and checking them on 121.52.146.108 (student's panel) :(

Secondly are you downloading the same zip file of Assignment, you checked in back-end folder.

from autograder.

recluze avatar recluze commented on May 26, 2024

Right. So, I guess I have found a way to reproduce the bug.

If you add an assignment and at that time add a "other file", it doesn't go in the zip file.

But if you go back to the assignment and hit "save" again, this time it does get put in the zip.

I guess the reason is that when you are saving the assignment, you save the assignment first (and at that time there are no "other files" since those are lower down in the hierarchy). After you save it once, the child node gets created and next save creates the proper zip.

from autograder.

recluze avatar recluze commented on May 26, 2024

Seems to be working fine now (even though the solution isn't too elegant since it will generate the zip after saving each 'other_file'). Maybe we can keep this open with low priority for this fix.

from autograder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.