Code Monkey home page Code Monkey logo

Comments (5)

tdanford avatar tdanford commented on August 16, 2024

I want to use the AdamContext.adamLoadVariantContext method in the depth calculation, rather than parsing our own VCFs by hand, but I'm going to have to fix this issue first: #127

from adam.

fnothaft avatar fnothaft commented on August 16, 2024

You may want to hold on that fix; I'd say that issue #127 should be a "won't fix" as the new VCF code from Mt. Sinai should address this issue.

from adam.

tdanford avatar tdanford commented on August 16, 2024

@nealsid is this related to the changes you were talking about, on IRC?

from adam.

nealsid avatar nealsid commented on August 16, 2024

One aspect where our pending PR will help is to isolate the fields that need to be compared for the join into ADAMVariant. So you can write utility functions to do field-by-field comparison (which already exists), or the necessary for logic to do range comparisons on ADAMVariant. Then a new record type that needs to be attached to a location on the chromosome can just contain ADAMVariant and get the range join almost for free, rather than having to extend it to look at the location fields directly in a new record type.
But after writing this out of course I realized that joining based on genomics coordinates may not only be related to variants and annotation databases, so maybe we should factor it out a bit more even.

from adam.

tdanford avatar tdanford commented on August 16, 2024

This has been fixed for a while; closing.

from adam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.