Code Monkey home page Code Monkey logo

Comments (7)

bigcat88 avatar bigcat88 commented on August 23, 2024

I am not sure that it is not set, need to check, earlier versions of libheif was able to set it, but was not able to retrieve it after set, as libheif does not support reading of nclx embedded in stream and not in image.
And during encoding libheif embeds it in stream.
I will take a look today at this.

from pillow_heif.

bigcat88 avatar bigcat88 commented on August 23, 2024

https://github.com/strukturag/libheif/blob/794a791b5048ff2bcdb6507c4413719652f568cf/libheif/heif.h#L997-L1002

When libheif will add such ability, I immediately will add tests for this in pillow_heif, as I myself waiting for it.

from pillow_heif.

wiggin15 avatar wiggin15 commented on August 23, 2024

Are you saying that the NCLX data is indeed stored, but not read?

I have a HEIC file (that I can't share, unfortunately) where there are multiple images and each of them does have the information read correctly by pillow-heif

from pillow_heif import open_heif
i = open_heif("myfile.heic")
i[0].info['nclx_profile']  # working
i[1].info['nclx_profile']  # working

I'm trying to construct a similar file using:

primary_pil.save(..., append_images=[secondary_pil])

and putting the nclx_profile on both PILs' info.
I'm not entirely sure how my HEIC was generated but I'd be surprised if they didn't use libheif themselves...

from pillow_heif.

bigcat88 avatar bigcat88 commented on August 23, 2024

This is real, a perfect issue.

Thank you for pointing on this.
Need to set macOS_compatibility_workaround_no_nclx_profile flag to false, to make it works.
But in current version it is not possible.

Will try to do a fix for a new one that is coming.

from pillow_heif.

bigcat88 avatar bigcat88 commented on August 23, 2024

Done. New version will be published, as soon as Python3.12 RC1 will come and cibuildwheel will get update for it(early August).

from pillow_heif.

bigcat88 avatar bigcat88 commented on August 23, 2024

done, new version is out

from pillow_heif.

bigcat88 avatar bigcat88 commented on August 23, 2024

P.S.: In new upcoming version #171 NCLX is saved by default.

from pillow_heif.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.