White border/trim around terminal even with 0px padding about drop-down-terminal-x HOT 6 CLOSED

Similar to #28, gap is gone now but white trim remains.

from drop-down-terminal-x.

This is still occurring on Pop_OS! with both the current git and gnome extensions channels. I will fix it myself and post it.

from drop-down-terminal-x.

Approved, I saw this on clean ubuntu install

from drop-down-terminal-x.

The reason is custom theme. With adwaita there is no any borders even in ubuntu.

from drop-down-terminal-x.

The reason is custom theme. With adwaita there is no any borders even in ubuntu.

If you look carefully even with Adwaita (first image) there is still a trim but it is less apparent, but the exact same problem is present, see the screenshots I have attached. The second screenshot is a custom theme (materia) where the trim is more apparent because of the different opacity level of the background in the custom theme. So the problem appears to be theme independent.

from drop-down-terminal-x.

commit 53e0bc97b122b0d810adffb9c358e7caae2989a6
Author: Aman Khosa <[email protected]>
Date:   Thu Oct 10 23:39:00 2019 +0100

    Tweak padding

diff --git a/[email protected]/extension.js b/[email protected]/extension.js
index e909cc0..be6755f 100644
--- a/[email protected]/extension.js
+++ b/[email protected]/extension.js
@@ -597,10 +597,10 @@ const DropDownTerminalXExtension = new Lang.Class({
         break
     }
 
-    this._windowX = this._windowX + leftPadding
-    this._windowY = this._windowY + topPadding
-    this._windowWidth = this._windowWidth - leftPadding - rightPadding
-    this._windowHeight = this._windowHeight - topPadding - bottomPadding
+    this._windowX = this._windowX + leftPadding - 1
+    this._windowY = this._windowY + topPadding - 1
+    this._windowWidth = this._windowWidth - leftPadding - rightPadding + 2
+    this._windowHeight = this._windowHeight - topPadding - bottomPadding + 2
 
     // applies the change dynamically if the terminal is already spawn
     if (this._busProxy !== null && this._windowHeight !== null) {

This quick hack removes the trim, so the problem is likely near this part of the code.

from drop-down-terminal-x.