Code Monkey home page Code Monkey logo

Comments (11)

samyael avatar samyael commented on August 16, 2024 5

I was having the same issue. Fixed it by disabling Tweaks > Windows > Center New Windows

Gnome-Shell 3.32.1 Wayland
Arch Linux

from drop-down-terminal-x.

bigbn avatar bigbn commented on August 16, 2024 2

But it work's fine under Arch linux, so maybe this is mainstream bug what will be fixed in next ubuntu release in April.

from drop-down-terminal-x.

mathewmeconry avatar mathewmeconry commented on August 16, 2024 1

I have the same issue on Fedora 30 with Gnome 3.32.2.

The work around from @samyael worked for me

from drop-down-terminal-x.

bigbn avatar bigbn commented on August 16, 2024

Which distro do you use? Could you attach screenshot?

from drop-down-terminal-x.

eode avatar eode commented on August 16, 2024

Settings screenshot
Popup screenshot

..if it's any help, you're not alone in having placement issues in Wayland. :-)

I'm using Ubuntu 18.10.

from drop-down-terminal-x.

bigbn avatar bigbn commented on August 16, 2024

Sorry but right now I don't see any way how to fix it.
Ubuntu in "wayland mode" doesn't provide wm_class for any starting window under gnome-shell execution.

This line always receives null under wayland:

if (window.get_wm_class() != TERMINAL_WINDOW_WM_CLASS) {

So extensions can't recognize when terminal window is appear, and can't apply clip for it.
Maybe somebody have ideas how to solve this?

from drop-down-terminal-x.

BeastCraiser avatar BeastCraiser commented on August 16, 2024

I experience the same bug when using Manjaro with Wayland (Gnome 3.30), @bigbn Which Gnome version do you use in Arch (maybe 3.31 fixes the issue)?

from drop-down-terminal-x.

bigbn avatar bigbn commented on August 16, 2024

3.30.2

from drop-down-terminal-x.

bigbn avatar bigbn commented on August 16, 2024

Wayland support still is a open question, because this application uses mechaincs that no available in wayland by design.
I'm not author of original extension (you know this is just a fork), so some of it logic is still magic even for me ). The extension must know which window is opened now to adjust it position and geomerty, but in wayland this is protected area.

from drop-down-terminal-x.

eode avatar eode commented on August 16, 2024

If it's any help, it attaches to the top when there are other applications present, but not when it's the only thing show on the desktop.

from drop-down-terminal-x.

xanf avatar xanf commented on August 16, 2024
diff --git a/[email protected]/extension.js b/[email protected]/extension.js
index 3b13f78..6fe2ed4 100644
--- a/[email protected]/extension.js
+++ b/[email protected]/extension.js
@@ -55,7 +55,7 @@ const ANIMATION_CONFLICT_EXTENSION_UUIDS = [
 ]
 
 const TERMINAL_WINDOW_ACTOR_NAME = 'dropDownTerminalXWindow'
-const TERMINAL_WINDOW_WM_CLASS = 'DropDownTerminalXWindow'
+const TERMINAL_WINDOW_WM_CLASS = 'drop-down-terminal-x'
 
 const FIRST_START_SETTING_KEY = 'first-start'
 const ENABLE_ANIMATION_SETTING_KEY = 'enable-animation'
@@ -251,7 +251,7 @@ const DropDownTerminalXExtension = new Lang.Class({
 
     // animation setup
     this._display = global.screen ? global.screen.get_display() : global.display
-    this._windowCreatedHandlerId = this._display.connect('window-created', Lang.bind(this, this._windowCreated))
+    this._windowCreatedHandlerId = this._display.connect('window-created', GLib.timeout_add(0, 1, Lang.bind(this, this._windowCreated)))
     this._actorMappedHandlerId = global.window_manager.connect('map', Lang.bind(this, this._windowMapped))
 
     // geometry update on monitor configuration change or panel size change

This one at least partially fixes this one for me:

  • window is properly positioned (it seems wm_class is being set in wayland a bit later and different value)
  • terminal copy/paste dialog is misaligned
  • applying settings when dropdown is open moves it to wrong position but fixes when it opens/closes

@bigbn let me know, if you think we could live with that limitations and I will wrap it to saner MR (not breaking Xorg wm_class)

from drop-down-terminal-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.