Code Monkey home page Code Monkey logo

Comments (9)

bhushankummar avatar bhushankummar commented on May 20, 2024

@charliecode
We are working on this. We will update you back ASAP.

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

Wondering what I can do to help make some progress with this. I'm looking through your code now trying to figure out where and how I can return status codes. Any pointing in the right direction is greatly appreciated, thanks so much for this awesome library, it's helped me out a ton.

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

I just tested this on my system and it successfully sent back the statusCode in an error response. Not sure if anything else should be done to handle this correctly but here it is for what it's worth. In AmazonMwsResource.js in the processResponseType() you can add the following below line # 185, "items.ErrorResponse.Error.statusCode = res.statusCode;". For me this successfully sends back Amazon's res statusCode, I believe.

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

Actually this would work better. In AmazonMwsResource.js in the processResponseType() you can add the following below line # 185,

if (items.ErrorResponse) {
items.ErrorResponse.Error.statusCode = res.statusCode;
}

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

Actually again lol, maybe it's better to add "errorResponse.statusCode = res.statusCode;" below line 236.

from amazon-mws.

bhushankummar avatar bhushankummar commented on May 20, 2024

@charliecode
Well, I have already done it. But I was not able to regenerate same error.
Can you please check for development branch and confirm that it's working as expected?

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

@bhushankumarl
It is working as expected. I simulated an error by leaving out one of the required parameters for the MWS request I am making. I see the StatusCode on both errors and normal successful requests, which is great. So I believe you can push to 'master' and add to NPM.

from amazon-mws.

charliecode avatar charliecode commented on May 20, 2024

@bhushankumarl Have you had a chance to load this change live to NPM? I would really like to add this functionality to my project, thanks so much for you help with this. This project is awesome!

from amazon-mws.

bhushankummar avatar bhushankummar commented on May 20, 2024

@charliecode
Corrected in https://github.com/bhushankumarl/amazon-mws/releases/tag/v0.0.19

from amazon-mws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.