Comments (13)
R0CKSTAR, thanks for filing this bug report!
Am I correct in believing that tapping a BFPaperButton/BFPaperTableViewCell pushed a new view on the Navigation Stack?
I'll be investigating this issue this week. Hopefully I can release a fix soon.
from bfpaperbutton.
Sorry, I have another question:
Are you setting the tap-circle color to that gray? Is that gray to be expected?
from bfpaperbutton.
I'm using smart color but always select gray, I don't know why. Please also investigate this...
@implementation ZSHPlainButton
- (void)dealloc
{
NSLog(@"dealloc");
}
+ (instancetype)button
{
return [[self alloc] initFlat];
}
- (void)action:(id)sender
{
if (self.click) {
self.click(sender);
}
}
- (void)setup
{
self.cornerRadius = 0;
self.isRaised = NO;
self.usesSmartColor = YES;
[self addTarget:self action:@selector(action:) forControlEvents:UIControlEventTouchUpInside];
}
- (id)init
{
self = [super init];
if (self) {
[self setup];
}
return self;
}
- (id)initWithFrame:(CGRect)frame
{
self = [super initWithFrame:frame];
if (self) {
[self setup];
}
return self;
}
- (id)initWithCoder:(NSCoder *)aDecoder
{
self = [super initWithCoder:aDecoder];
if (self) {
[self setup];
}
return self;
}
from bfpaperbutton.
The last question is YES, pushing a new view controller than swiping back, and the screenshots are taken from intermediate states, when the last view controller receives viewDidAppear, everything goes right.
from bfpaperbutton.
About the gray color:
If you use smart color, BFPaperButton tries to match the color to self.titleLabel.textColor and BFPaperTableViewCell tries to match the color to self.textLabel.textColor. Are you setting these properties?
Is the circle still gray if you explicitly set the tap-circle color (eg: control.tapCircleColor = [UIColor redColor];) ?
from bfpaperbutton.
.tapCircleColor = [UIColor redColor]; this will change the circle color.
It could be smarter if considering the background color or background image color or image color for certain state :)
https://github.com/timominous/TDImageColors
from bfpaperbutton.
I see. Thanks I will take a look and perhaps include the ability to choose where smart color looks to match the circle in the next version.
As for the animation getting paused and resumed by the Navigation Stack transition animations, I really don't know if that is something I can control from the UIButton level. It seems like the animation is performing as expected, but I will continue looking into this.
Thanks.
from bfpaperbutton.
Thanks for taking time investigating this.
from bfpaperbutton.
I just confirmed this strange and unwanted behavior:
Will work on a fix for this ASAP.
Thanks again for finding this!
from bfpaperbutton.
Great, looking forward to your fix, thanks.
from bfpaperbutton.
Version 1.5.1 fixes the gray layer and circles being left behind and showing up during Navigation Stack transitions, and 1.5.2 is the latest build. Please update and let me know if you find any more bugs, thanks!
(I am rolling the same update to the rest of the BFPaper components today as well.)
I am considering adding options to make Smart Color more smart in the future, thank you :)
from bfpaperbutton.
BFPaperTableViewCell version 1.2.1 applies the same fix to that library.
from bfpaperbutton.
Nice, thanks!
from bfpaperbutton.
Related Issues (20)
- hi~ I have found a problem with the button HOT 11
- the button does not work when it is created in a UITableViewCell HOT 12
- Fast touch up inside HOT 2
- tapCircleDiameter and different growth depending on longpress and normal touch HOT 5
- Use with Storyboard and IB?
- only really notice effects on long press HOT 8
- Swift 2.0 Version HOT 6
- How to use it with Storyboard? HOT 2
- Animations can't play when Buttons in UIScrollView HOT 3
- Run is not smooth HOT 3
- Animation on button doesn't work when button's parent ViewController is embed into a container view (i.e child viewController) HOT 4
- You have this bug HOT 3
- layoutSubviews ignores enabled property HOT 1
- bug HOT 2
- FEATURE REQUEST : Button Radius HOT 1
- Get rid of dots HOT 3
- Raised using Storyboard
- Crash iOS 9.2 below archive by xcode 10.1
- Problem : delegate for global animation
- Disabled state for raised button no longer removes shadow after tapped at least once. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bfpaperbutton.