Code Monkey home page Code Monkey logo

Comments (15)

bezzad avatar bezzad commented on May 19, 2024 4

@ghost1372, @GihanSoft
I consulted with somebody in this regard. The result was that this feature is quite simple to implement on the same package (due to the simplicity and closeness of this concept to the downloader package). But if there will be a lot of feature requests for about download manager in the future, which would make the project larger, then that would make sense to separate it from the project and package it independently.

If there is an issue, raise it here.
Thanks

from downloader.

bezzad avatar bezzad commented on May 19, 2024 3

I trying to add this feature as soon as possible. Thanks for your feedback.

from downloader.

lindexi avatar lindexi commented on May 19, 2024 3

@ghost1372 Sorry, I will not do that. Because we can do this in business code.

from downloader.

ghost1372 avatar ghost1372 commented on May 19, 2024 3

I think it's a small feature and, as you said, there's no need for dependency. this is an almost independent feature that has nothing to do with the DownloadService So we do not need to publish through another package! If this feature is implemented properly, It will meet many needs.

from downloader.

GihanSoft avatar GihanSoft commented on May 19, 2024 1

@bezzad I think it's even better not adding this DownloadManager class in main package. I think putting it in another NuGet is better way.

from downloader.

ghost1372 avatar ghost1372 commented on May 19, 2024

@bezzad thank you
@lindexi how about this?Will you add this feature?

from downloader.

ghost1372 avatar ghost1372 commented on May 19, 2024

any news?

from downloader.

GihanSoft avatar GihanSoft commented on May 19, 2024

@ghost1372 Sorry, I will not do that. Because we can do this in business code.

I thing it's better to be handled by client code. adding this in library is not good. At least using a subclass for it may be better.

from downloader.

bezzad avatar bezzad commented on May 19, 2024

@GihanSoft that's right to handle it from the client-side. But I write a simple DownloadManager class that can be used to list IDownloadService and manage downloaders concurrency degrees.

When you want to use a list of downloaders and manage themselves manually, There may be some issues that are difficult to manage without the downloader, for example:

  • handling progress events per each downloader
  • handle download completion or cancellation events
  • Know when you can start the next download in from queue
  • Adding a new download to the list in progress time.
  • ...

Anyway, you can have your download manager and don't use this new DownloadManager class and only have the Downloader in your program, because there will be no dependency between these two classes in this library.

I'm very glad of your opinion and feel free to request a new feature for the download manager or continue this discussion.

from downloader.

ghost1372 avatar ghost1372 commented on May 19, 2024

@bezzad I think it's even better not adding this DownloadManager class in main package. I think putting it in another NuGet is better way.

I disagree

from downloader.

bezzad avatar bezzad commented on May 19, 2024

@GihanSoft as I said, I agree with you, Because, when we use the download manager, we do not need a downloader, and vice versa, if we use the downloader directly, it means that we want to control the download process ourselves and we do not want the download manager to do it for us.

Therefore, the best thing to do at this point is to use a separate package from the downloader.
For a better result, we can discuss again :)

from downloader.

bezzad avatar bezzad commented on May 19, 2024

@ghost1372 Why you don't agree?

from downloader.

ghost1372 avatar ghost1372 commented on May 19, 2024

@ghost1372, @GihanSoft
I consulted with somebody in this regard. The result was that this feature is quite simple to implement on the same package (due to the simplicity and closeness of this concept to the downloader package). But if there will be a lot of feature requests for about download manager in the future, which would make the project larger, then that would make sense to separate it from the project and package it independently.

If there is an issue, raise it here.
Thanks

now i agree 😅

from downloader.

Ruddy2007 avatar Ruddy2007 commented on May 19, 2024

@bezzad So is another project taking over this feature request or is this something for users of the package to handle?

Little confused as the issue has not been closed.

from downloader.

bezzad avatar bezzad commented on May 19, 2024

@Ruddy2007 This feature is out of this project goal and if we want to create a class to manage a list of downloads, it will be upper level than the DownloaderService and it can't be implemented now.
I decided to create a new project to do this feature.

from downloader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.