Comments (15)
@ghost1372, @GihanSoft
I consulted with somebody in this regard. The result was that this feature is quite simple to implement on the same package (due to the simplicity and closeness of this concept to the downloader package). But if there will be a lot of feature requests for about download manager in the future, which would make the project larger, then that would make sense to separate it from the project and package it independently.
If there is an issue, raise it here.
Thanks
from downloader.
I trying to add this feature as soon as possible. Thanks for your feedback.
from downloader.
@ghost1372 Sorry, I will not do that. Because we can do this in business code.
from downloader.
I think it's a small feature and, as you said, there's no need for dependency. this is an almost independent feature that has nothing to do with the DownloadService So we do not need to publish through another package! If this feature is implemented properly, It will meet many needs.
from downloader.
@bezzad I think it's even better not adding this DownloadManager
class in main package. I think putting it in another NuGet is better way.
from downloader.
@bezzad thank you
@lindexi how about this?Will you add this feature?
from downloader.
any news?
from downloader.
@ghost1372 Sorry, I will not do that. Because we can do this in business code.
I thing it's better to be handled by client code. adding this in library is not good. At least using a subclass for it may be better.
from downloader.
@GihanSoft that's right to handle it from the client-side. But I write a simple DownloadManager class that can be used to list IDownloadService and manage downloaders concurrency degrees.
When you want to use a list of downloaders and manage themselves manually, There may be some issues that are difficult to manage without the downloader, for example:
- handling progress events per each downloader
- handle download completion or cancellation events
- Know when you can start the next download in from queue
- Adding a new download to the list in progress time.
- ...
Anyway, you can have your download manager and don't use this new DownloadManager
class and only have the Downloader in your program, because there will be no dependency between these two classes in this library.
I'm very glad of your opinion and feel free to request a new feature for the download manager or continue this discussion.
from downloader.
@bezzad I think it's even better not adding this
DownloadManager
class in main package. I think putting it in another NuGet is better way.
I disagree
from downloader.
@GihanSoft as I said, I agree with you, Because, when we use the download manager, we do not need a downloader, and vice versa, if we use the downloader directly, it means that we want to control the download process ourselves and we do not want the download manager to do it for us.
Therefore, the best thing to do at this point is to use a separate package from the downloader.
For a better result, we can discuss again :)
from downloader.
@ghost1372 Why you don't agree?
from downloader.
@ghost1372, @GihanSoft
I consulted with somebody in this regard. The result was that this feature is quite simple to implement on the same package (due to the simplicity and closeness of this concept to the downloader package). But if there will be a lot of feature requests for about download manager in the future, which would make the project larger, then that would make sense to separate it from the project and package it independently.If there is an issue, raise it here.
Thanks
now i agree 😅
from downloader.
@bezzad So is another project taking over this feature request or is this something for users of the package to handle?
Little confused as the issue has not been closed.
from downloader.
@Ruddy2007 This feature is out of this project goal and if we want to create a class to manage a list of downloads, it will be upper level than the DownloaderService and it can't be implemented now.
I decided to create a new project to do this feature.
from downloader.
Related Issues (20)
- DownLoad as url HOT 1
- Using in .Net Maui App HOT 1
- Callback error occurred when using version 3.0.4 HOT 7
- The calling thread cannot access this object because another thread owns it HOT 1
- ExceptionHelper.CertificateValidationCallBack() is never called when compiling for android HOT 3
- Chunk displaying no progress yet still downloads. HOT 1
- No error when server responds with 404 HOT 1
- Occasional resume error and inaccurate download progress HOT 2
- Whether the download can be resumed from where the last download was not completed HOT 3
- ipv6 Download error the ssl connection could not be established, see inner exception HOT 2
- RobiniaDocs API Explorer
- how to download stream or api link?
- Large file download blocks other download tasks. HOT 3
- Attempting to download the same file to the local directory with same name doesnt overwrite/replace HOT 2
- Downloader support socks5 proxy HOT 3
- getting error when download completed! HOT 11
- The 67th Line in this file“Downloader/src/Downloader /ChunkDownloader.cs ” is not need HOT 1
- The CancelTaskAsync interface of IDownloadService causes the program to freeze. HOT 1
- Inquiry Regarding Repository Usage for Efficient Download of Small Files in .NET HOT 1
- I need to implement happy eyeballs for IPV4 IPV6 dual stack protocol HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from downloader.