betteruptime_monitor - monitor_type expected_status_code is missing about terraform-provider-better-uptime HOT 11 CLOSED

@adikus works like a charm, thanks!

from terraform-provider-better-uptime.

This was added in ce3496b

However if configured, terraform wants to update in-place the resource each time it's run even if there is no change.

from terraform-provider-better-uptime.

Closing this, as the issues with expected_status_code should be now fixed on the API side.

from terraform-provider-better-uptime.

@adikus, just tested and still the same issue.

from terraform-provider-better-uptime.

@hydrapolic which version of the plugin are you using? I just tested this with the latest one, and creating / updating a monitor with an expected_status_code worked as I would expect.

If you're on the latest version (0.3.8), could you please share your terraform config at [email protected] so that we can have a look?

from terraform-provider-better-uptime.

@adikus I'm using version 0.3.8.

When issuing terraform plan, it's stated that the monitors will be updated in place. Of course there's nothing wrong with it, but in fact the value of expected_status_codes haven't changed at all so it should state "no change".

from terraform-provider-better-uptime.

Just checked the output again. It seems like it only happens for monitors that had expected_status_codes defined previously but then we turned it off (for example we started monitoring a service that returned 404 for url /, but later it was changed to 200 so expected_status_codes was unnecessary).

from terraform-provider-better-uptime.

How to reproduce:

1. set up a monitor with monitor_type = expected_status_code and fill in expected_status_codes (for example 200/404)
2. change monitor_type to status

# terraform apply
  # monitor will be updated in-place
  ~ resource "betteruptime_monitor" "monitor" {
      ~ expected_status_codes = [
          - 200,
          - 404,
        ]
      ~ monitor_type          = "expected_status_code" -> "status"

terraform apply
  # monitor.monitor will be updated in-place
  ~ resource "betteruptime_monitor" "monitor" {
      ~ expected_status_codes = [
          - 200,
          - 404,
        ]
        # (21 unchanged attributes hidden)
    }

from terraform-provider-better-uptime.

@hydrapolic Thanks for the instructions on how to reproduce. Looks like we're not allowing for the expected status codes to be unset once they've been set. I'll have a look into that.

In the meantime it sounds like the workaround, if I can call it that, is to keep some status code in there (e.g. [200]), even if it's not going to be used.

from terraform-provider-better-uptime.

An alternative to that is to ignore changes in expected_status_codes once they are applied:

lifecycle {
  ignore_changes = [
    expected_status_codes
   ]
}

from terraform-provider-better-uptime.

@hydrapolic We rolled out a change to the API, so when you completely remove expected_status_codes it will get correctly propagated.

from terraform-provider-better-uptime.