Code Monkey home page Code Monkey logo

Comments (8)

MarioUhrik avatar MarioUhrik commented on May 19, 2024 3

I agree with @MiroslavRepka. The tools can be baked into the image with a pinned version. Actually, they really should be. I can't imagine how it was ever working without that.

Unless I am understanding incorrectly, #55 is not a reason to increase the priority of using Terraform and KubeOne via Golang API. We can pin Terraform and KubeOne versions in the Dockerfile instead, in a very cheap manner.

Forgive me if I misunderstand the situation, I just wanted to present this option to you @bernardhalas @MiroslavRepka .

from claudie.

MiroslavRepka avatar MiroslavRepka commented on May 19, 2024 1

The respective tools also need to be included in Dockerfile for each service. Right now, the docker images do not contain those tools, since we are testing Claudie locally.

from claudie.

samuelstolicny avatar samuelstolicny commented on May 19, 2024 1

I think too that including the right Terraform, Ansible, and KubeOne versions in dockerfile is enough. And about go libs, as @MiroslavRepka told on today's standup, they are taken care of in go.mod file.

Yeah, currently we are using tools from localhost, but it is only a temporary solution and it will change really soon, after merging feature/delete-node branch.

from claudie.

samuelstolicny avatar samuelstolicny commented on May 19, 2024

I propose this tools versions:

  • Kubeone: 1.2.3
  • Terraform: v1.0.0
  • Ansible: 2.11.0

... or these are versions that I am currently using.

from claudie.

samuelstolicny avatar samuelstolicny commented on May 19, 2024

Is this bug still valid? As far as I know, all versions are defined in docker files.
@bernardhalas @MarioUhrik @borkaz

from claudie.

borkaz avatar borkaz commented on May 19, 2024

Is this bug still valid? As far as I know, all versions are defined in docker files. @bernardhalas @MarioUhrik @borkaz

From what I can see kubeOne is set to 1.2.3, Terraform is set to 1.0.0, and the latest Ansible pkg version is used.

from claudie.

samuelstolicny avatar samuelstolicny commented on May 19, 2024

From what I can see kubeOne is set to 1.2.3, Terraform is set to 1.0.0, and the latest Ansible pkg version is used.

We should define a version of Ansible.

from claudie.

borkaz avatar borkaz commented on May 19, 2024

Task review: Issue was resolved by pinning Ansible (the only component found to be not already pinned) to a specific version in PR #100 'Pinpoint ansible version' implemented and merged by @samuelstolicny.

from claudie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.