Code Monkey home page Code Monkey logo

Comments (12)

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

notify Hakan ... I would do, if anyone tell me how ! everthing's ready.

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

Ok, ready,
now it's time to notify Hakan,
to pot file in your Repro is newest. the po for german, french, dutch, spain do not work, but you wrote, the will be updated over crowdin.
It would be good, when at least the "german" po file would be taken from my Repro, and not be made new !! I think, this is what I will do best myself.

from raymarine_autopilot_pi.

rgleason avatar rgleason commented on August 28, 2024

@Hakansv Bernd would like to notify you to please update the pot and po files, because the newest po for german, dutch and spanish do not work.

Is it correct that the best way to enter these translations for german dutch and spanish is to register for crowdin account, and become a translator for OpenCPN and Plugins? Otherwise local changes will always be overwritten?

Hakan, I think you should clone bernd's account for raymarine_pypilot and push changes to his account. Thanks.

(I made a PR to Bernd and had to resolve conflicts because of his more recent changes to autopilot_pi.cpp and all the po files. When resolving those conflicts I accepted Bernd's po files but they do not work because I believe the pot file changed. Is that possible? I did not notice any conflict there.)

from raymarine_autopilot_pi.

Hakansv avatar Hakansv commented on August 28, 2024

@Hakansv Bernd would like to notify you to please update the pot and po files, because the newest po for german, dutch and spanish do not work.

Not working?? In more details please. But see below..

Is it correct that the best way to enter these translations for german dutch and spanish is to register for crowdin account, and become a translator for OpenCPN and Plugins? Otherwise local changes will always be overwritten?

If Crowdin is used the translators enter there translations for each language.
When PR po-files from Crowdin existing ones will be updated not overwritten. If possible.

Hakan, I think you should clone bernd's account for raymarine_pypilot and push changes to his account. Thanks.

(I made a PR to Bernd and had to resolve conflicts because of his more recent changes to autopilot_pi.cpp and all the po files. When resolving those conflicts I accepted Bernd's po files but they do not work because I believe the pot file changed. Is that possible? I did not notice any conflict there.)

If the strings to translate in the code are changed or new added, a new pot-file has to be created and loaded to Crowdin.
If the use of Crowdin is not desired the pot-file has to be used by e.g. peoedit and perform all translations there. That will create updated po-files to commit locally.
But..
If the code is changed and you want to load new strings to Crowdin I can of course serve that.
(If a po-file created locally is more complete just save it somewhere else before merge of a PR and copy it back afterwords.)
Bernd, if you think Crowdin is of no help we can of course take this plugin out?

Many words but here's a suggestion:
Looking at what's yesterday in Crowdin the translator's haven't put much of interest in this plugin
es_ES.po is 100% translated.
fr_FR is 65% translated.
For the rest nothing is done. Could that be what you say "not working"?

So, You could use your own po-files and copy the two mentioned above to your own repo?
I have attached two files:

po_files.zip

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

???
Now I don't understand anything. Rick say ... must to crowdin , now you say must not, and will be updated and not overwritten .?!
For me it really does not matter. I have 4 correct translation in my Repo. "de, nl, fr, es" and they work. I Only wanted them to upload to Rick's Repo, but always when doing it, there are conficts or they are wrong updated or overwritten. ...or what ever?!?

The 4 po files in Ricks Repro do not work because ... C- Compiler errors. (wrong updated ?)
..... Output errors (example for de) Doubledefinition :
C:/Users/Home PC 64Bit/Downloads/raymarine_autopilot_pi-master/po/de_DE.po:175: Mehrfachdefinition der Meldung...
1>C:/Users/Home PC 64Bit/Downloads/raymarine_autopilot_pi-master/po/de_DE.po:79: ...dies ist die Stelle der ersten Definition
1>C:\Program Files (x86)\Poedit\GettextTools\bin\msgmerge.exe: es ist 1 fataler Fehler aufgetreten

the easiest way I think is now to make a PR to Rick, with the 4 working po files, and they will not be changed be crowdin.

from raymarine_autopilot_pi.

Hakansv avatar Hakansv commented on August 28, 2024

The use of Crowdin is not mandatory for a plugin but can be a help for users from different countries. But we have to rely on efforts from human translators. And for this plugin there is so far not much interest.
If you have four good translation files do use them and forget the files from Crowdin so far. I agree.

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

And for this plugin there is so far not much interest.
Yes I think so it's very special.

what should I do now ?

from raymarine_autopilot_pi.

rgleason avatar rgleason commented on August 28, 2024

Ok Bernd, I cannot fathom why my resolution of conflicts in favor of your language changes did not work flawlessly, and would like to understand why.

Ok, I will make a PR from your repos to mine and see if it works.

Perhaps you problem has more to do with opencpn-libs not being updated?
I noticed that the opencpn-libs submodule branch has not been updated on your repository.
Are you sure it has been updated? There were some changes to opencpn-libs that you should have. This requires you to execute some git commands for updating the submodule. Scroll to the bottom and try
https://github.com/OpenCPN/opencpn-libs#updating-to-latest-status

Very sorry about all the trouble.

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

No my Repro works !! I have fix everthing !
Ricks dose not work, because he has the wrong po files. And he is the manager of plugins.

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

... sorry misunderstood. Ok Rick do it.

from raymarine_autopilot_pi.

rgleason avatar rgleason commented on August 28, 2024

Ok from the github web user interface, I will select "Pull Request" and make a "Compare" and then merge, keeping a careful eye on the direction. I hope we won't have conflicts this time.

rgleason/raymarine_autopilot <---- BerndCirotzki/raymarine_autopilot_pi

from raymarine_autopilot_pi.

BerndCirotzki avatar BerndCirotzki commented on August 28, 2024

OK

from raymarine_autopilot_pi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.