Error after create a tenant about django-tenant-schemas HOT 11 CLOSED

Do you have a tenant with the same domain where your request is going?
For example, do you have a host with domain_name "first.example.com" when you get the page from http://first.example.com ?

from django-tenant-schemas.

No, i didn't. I was creating a tenant with domain_url "client1.example.com" from the public schema in "example.com". And that was the first tenant (also failed with second and third tenant), so I didn't have any tenant with that url.

If I use my fork, from a few weeks ago (https://github.com/jjimenezlopez/django-tenant-schemas), the error does not occurs.

from django-tenant-schemas.

Did you successfully create the public schema with every table synced before the client1 tenant?

from django-tenant-schemas.

Yes, the public schema was created correctly and without errors. Then, when I tried to create the tenant schema, it was created and all tables were synced, but gave me that error after that.

from django-tenant-schemas.

Check if the changes in #62 have any effect on this behavior. We basically restricted the tenant_creation into public tenant and modification into public and current tenant's domain, but I don't this change is causing this, but might worth a look.

from django-tenant-schemas.

Sorry for the ultra late reply. It looks like you have overwritten the
save() method on your tenant model, as there is no call to admin_user
on this app's code. Is this correct? Can you please post the code of this
method here? This will give us the insight needed to fix your problem.

2013/9/4 Walkman [email protected]

Check if the changes in #62https://github.com/bcarneiro/django-tenant-schemas/issues/62have any effect on this behavior. We basically restricted the
tenant_creation into public tenant and modification into public and current
tenant's domain, but I don't this change is causing this, but might worth a
look.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-23789894
.

Bernardo Pires Carneiro

from django-tenant-schemas.

Hello @bcarneiro, thanks for your reply.

Here is my tenant save method:

    def save(self, admin_email=None, *args, **kwargs):

        if self.pk is None:
            # se está añadiendo
            self.schema_name = self.domain_url

        self.domain_url = '%s.%s' % (self.domain_url, settings.APP_DOMAIN)

        super(Customer, self).save(*args, **kwargs)

        if admin_email is not None:
            # creamos el usuario administrador del cliente
            with tenant_context(self):
                mail_edited = False
                new_password = generate_password()
                try:
                    admin_user = User.objects.get(username="admin")
                    if admin_email != admin_user.email:
                        mail_edited = True
                        admin_user.email = admin_email
                except User.DoesNotExist:
                    admin_user = User(username="admin", email=admin_email, is_staff=True)

                if mail_edited or admin_user.pk is None:
                    admin_user.set_password(new_password)
                    subject = _("my_project")
                    body = _(u"Ha sido registrado en my_project, su nuevo usuario es ")
                    body += "admin"
                    body += _(u" y su clave ")
                    body += new_password
                    send_mail(subject, body, settings.EMAIL_HOST_USER, [admin_email], fail_silently=True)

                admin_user.save()

Far as I understand, the code in the save method should not affect.

Thanks!

from django-tenant-schemas.

Alright, I think I know where the problem is. Your code is perfect Jose,
you don't have to change anything. This is a mistake in this app.

So here's what's happening and this is why it only started happening after
#62.

Jose uses with tenant_context(self):, which basically sets the
search_path to the given tenant on the with's scope and returns to the
previous schema when the with ends. tenant_context saves the current
tenant in previous_tenant, changes the search_path to the given tenant
and then calls connection.set_tenant(previous_tenant) at the end. The
problem in this case is that the current schema is public
because set_schema_to_public is called at the end of the save method.
set_schema_to_public sets self.tenant = None, so previous_tenant will
be None inside tenant_context. tenant_context then calls on the
end connection.set_tenant(previous_tenant) and fails. So the problem is,
tenant_context doesn't work if the current schema is public. This is
also why it only started happening after #62, as previously
previous_schema would be the tenant that was just created.

A quick fix could be to change the function set_schema_to_public to
actually fetch the public tenant.

    def set_schema_to_public(self):
        self.tenant = get_tenant_model().objects.get(schema_name=get_public_schema_name())
        self.schema_name = get_public_schema_name()

or to instantiate a fake public tenant (I'm not sure if this is going to
work, maybe we'll have to use TenantMixin instead. Important here is to
NOT save this fake instance)

    def set_schema_to_public(self):
        self.tenant = get_tenant_model()(schema_name=get_public_schema_name())
        self.schema_name = get_public_schema_name()

Thoughts? I'd be very grateful if someone could test and fix this bug!

Cheers,
Bernardo

from django-tenant-schemas.

Thanks for your help @bcarneiro, I will try it later.

from django-tenant-schemas.

I have been trying to fix this. For any reason I don't know, the get_tenant_model() method returns None when is called from postgresql_backend.base.py.

But I think I have found another solution. I have modified the tenant_context method:

@contextmanager
def tenant_context(tenant):
    previous_tenant = connection.get_tenant()

    # if previous_tenant is None, means that we are working with the public schema
    if previous_tenant is None:
        previous_tenant = get_tenant_model().objects.get(schema_name=get_public_schema_name())

    try:
        connection.set_tenant(tenant)
        yield
    finally:
        connection.set_tenant(previous_tenant)

What do you think guys? I think it makes sense.

from django-tenant-schemas.

Hi Jose,

thanks for the help! I don't like this solution of fixing it on
tenant_context, I think it doesn't really solve the problem in the right
way and schema_context would also have the exact same problem. A tenant
should always be available, so it needs to be set on set_schema_to_public.
I'll take a look later in the code if noone fixes it.

2013/9/10 Jose Jiménez [email protected]

I have been trying to fix this. For any reason I don't know, the *
get_tenant_model()* method returns None when is called from *
postgresql_backend.base.py*.

But I think I have found another solution. I have modified the *
tenant_context* method:

@contextmanagerdef tenant_context(tenant):
previous_tenant = connection.get_tenant()

# if previous_tenant is None, means that we are working with the public schema
if previous_tenant is None:
    previous_tenant = get_tenant_model().objects.get(schema_name=get_public_schema_name())

try:
    connection.set_tenant(tenant)
    yield
finally:
    connection.set_tenant(previous_tenant)

What do you think guys? I think it has sense.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-24172540
.

Bernardo Pires Carneiro

from django-tenant-schemas.