Comments (7)
The original patch used a reserved names for a few new internal helper
functions. This version of the patch uses names that are not reserved (but
might need to be changed if you have some naming requirements).
Original comment by [email protected]
on 9 Aug 2011 at 11:10
Attachments:
from snappy.
Hi,
Do you think you could make the patch against the latest Subversion checkout?
At least one of these issues (the workaround for SunPro's broken const
handling) have already been fixed there; I thought it would actually work then,
but obviously not.
Also, is there really any platform that doesn't have byteswap functions
builtin? If so, you most likely want a slightly more efficient variation than
this, e.g. for 32-bit
x = ((x & 0xffff0000) >> 8) | ((x & 0x0000ffff) << 8);
x = ((x & 0xff00ff00) >> 4) | ((x & 0x00ff00ff) << 4);
etc.
Original comment by [email protected]
on 9 Aug 2011 at 11:25
- Changed state: Accepted
from snappy.
I'll take a few minutes later this week to create patches from trunk. When I
made this patch I had looked around for any byteswap routines and didn't find
any. Upon reading your comments, I went back and found that they're there, but
use all uppercase names (in sys/byteswap.h).
Original comment by [email protected]
on 9 Aug 2011 at 11:37
from snappy.
I've included some of the simpler ones in trunk now, but the byteswap stuff is
still not in.
Do you think you could fill in the form at
http://code.google.com/legal/individual-cla-v1.0.html ? It is needed for us to
accept any kind of non-trivial patches.
Original comment by [email protected]
on 10 Aug 2011 at 6:58
from snappy.
btw, if you'd like an existing chunk of byteswap code you can pull in, feel
free to use the one in
http://code.google.com/p/google-ctemplate/source/browse/trunk/src/base/macros.h
This uses a number of configure.ac directives, which you can find in
http://code.google.com/p/google-ctemplate/source/browse/trunk/configure.ac
Original comment by [email protected]
on 10 Aug 2011 at 9:24
from snappy.
I'm pretty sure that bit of code is insufficient for platforms I need to
support (VisualAge C++ 11 on AIX 6.1 and HP aC++ 6.25 on HP-UX 11.31). I did a
thorough search through the system headers looking for byte swapping routines
or macros and turned up nothing on either platform.
Original comment by [email protected]
on 10 Aug 2011 at 9:34
from snappy.
The byteswap issue has been fixed in r49. (The fix also includes generic
macros, which should fix compilation for AIX and HP-UX.) I believe that closes
the issue.
Original comment by [email protected]
on 15 Sep 2011 at 9:51
- Changed state: Fixed
from snappy.
Related Issues (20)
- Various MSVC x64 compiler size_t warnings (C4267) HOT 6
- Does not handle data larger than 4GB HOT 8
- Mistakes on the start page HOT 5
- cppcheck - Member variable is not initialized in the constructor. HOT 2
- Type 'ssize_t' not defined for MSVC builds HOT 4
- snappy needs a command line utility HOT 5
- MIsspelled in code HOT 1
- testdata/mapreduce-osd-1-pdf contains "DO NOT DISTRIBUTE" disclaimer HOT 3
- Patch for compiling Snappy with MSVC on Windows HOT 3
- Bug in IncrementalCopyFastPath HOT 6
- use ctypes.util.find_library HOT 3
- ARMv6 and unaligned access HOT 3
- Decompression issues with Snappy 1.1.2 HOT 3
- ahsan ullah HOT 2
- Seeing Null Values from Hive with Snappy Compression HOT 1
- No versioned link for current build HOT 2
- ppc64le entry is needed in config.guess file HOT 4
- performance issue in snappy.cc - I am using version 1.1.2 HOT 2
- Unnecessary memory allocation in snappy.cc:Compress HOT 1
- bad_alloc exception not caught in snappy.cc::Compress
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from snappy.