Code Monkey home page Code Monkey logo

Comments (4)

berkerpeksag avatar berkerpeksag commented on August 17, 2024

Thank you for your report, @mdanatg. 0.6 was actually broken due to the way deprecate() function in astor/__init__.py implemented and it broke Hy: hylang/hy#1452

Adding

# Note that 'astor.codegen' is renamed to 'astor.code_gen'
# but it will stay until astor 1.0.
import astor.codegen

after

https://github.com/google/tangent/blob/ff9ffddd4f2cc5f6b51a29545fcd1d2a036773e8/tangent/quoting.py#L19

would fix the build for now.

I'll try to find a way to make both use cases work. Sorry for the trouble!

from astor.

berkerpeksag avatar berkerpeksag commented on August 17, 2024

@mdanatg I couldn't run tangent tests under my system because my glibc version was too old for Tensorflow (tensorflow/tensorflow#53), but I believe PR #88 fixed this issue.

I just released 0.6.2.

from astor.

mdanatg avatar mdanatg commented on August 17, 2024

@berkerpeksag Thank you for the quick fix!

Would it be useful for us to rename codegen to code_gen in out code base?

from astor.

berkerpeksag avatar berkerpeksag commented on August 17, 2024

We don't plan to remove old imports before version 1.0.0 (we may keep them even after 1.0.0 if we don't introduce more serious API changes) so I'd say it's OK to keep astor.codegen imports in the foreseeable future.

from astor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.