Code Monkey home page Code Monkey logo

Comments (3)

berkerpeksag avatar berkerpeksag commented on July 18, 2024

This looks more broken in astor 0.6:

>>> import astor
>>> import ast
>>> print (astor.to_source(ast.parse('a = 1e400')))
a = 1e1000

>>> print (astor.to_source(ast.parse('a = -1e400')))
a = -1e1000

@pmaupin do you know what causes this?

from astor.

pmaupin avatar pmaupin commented on July 18, 2024

@berkerpeksag :

Sorry I didn't document this fix better.

As described by the bug report, the behavior in 0.5 is broken -- inf can appear in the AST, but inf is not a reserved word in Python.

However, the suggested fix of using float('inf') will not round-trip properly; the call to float is embedded in the AST along with the string 'inf', so the generated AST does not match the original AST.

The only way I know of to create source code that will cause inf to be output in the AST is to use a number that is too big, so the current solution works and round-trips correctly, unless somebody has a python with more than 10 bits of exponent in a float. If anybody knows a more canonical way of doing this, that would be great, but the goal is to generate source code that will compile to having inf in the AST, not to generate a call to float along with a string.

BTW, thanks for all your great work on this!

from astor.

berkerpeksag avatar berkerpeksag commented on July 18, 2024

Ah, you're right. I definitely missed this:

astor/astor/code_gen.py

Lines 612 to 618 in 50d6d27

# Deal with infinities -- if detected, we can
# generate them with 1e1000.
signed = s.startswith('-')
if s[signed].isalpha():
im = s[-1] == 'j' and 'j' or ''
assert s[signed:signed + 3] == 'inf', s
s = '%s1e1000%s' % ('-' if signed else '', im)

I've added a test case and explicitly document this in the test so hopefully I won't forget again :)

Thanks!

from astor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.