code_to_ast can't extract methods in classes about astor HOT 4 OPEN

Sounds good, I'll put it together  👍

from astor.

Yeah, that function's pretty simple right now -- it only works on top-level functions.

Having said that, you can have functions inside classes inside functions inside functions inside classes inside...

Honestly, I don't even remember my use-case for writing that, but I suspect it had to do with testing the code writer.

We'd certainly accept a patch for a more-functional version of this, but I don't have a use-case at the moment.

Thanks,
Pat

from astor.

I wrote a version of the CodeToAst class for myself that recurses down the AST. Here's basically how it works.

I make a list of AST nodes, block_types, that have a body field (ast.If, ast.For, etc), and thus could contain a function. I also make a list of AST nodes, func_types, that are function definitions (ast.FunctionDef or ast.AsyncFunctionDef).

Then I have a method that descends the AST (note self.asts is equivalent to cache, and self.filename is equivalent to fname):

def _find_funcs(self, parent_ast):
    for item in parent_ast.body:
        if type(item) in self.func_types:
            self.asts[(self.filename, item.lineno)] = item
            self._find_funcs(item)
        elif type(item) in self.block_types:
            self._find_funcs(item)

I haven't tried to port this back to astor yet, but I could do that without much trouble if it sounds like what you're looking for.

from astor.

@zmitchell that seems like a reasonable approach to me, thank you. I'd be happy to review if you submit a PR.

from astor.