Code Monkey home page Code Monkey logo

Comments (3)

benweier avatar benweier commented on May 19, 2024

Hey @oliv-tree, the PVP Season API is currently available on the retail client but not on the classic client. Checking the documentation it does look like it is supported by the classic game data APIs now so I may need to add this to the lib

from blizzard.js.

oliv-tree avatar oliv-tree commented on May 19, 2024

Hey @oliv-tree, the PVP Season API is currently available on the retail client but not on the classic client. Checking the documentation it does look like it is supported by the classic game data APIs now so I may need to add this to the lib

Again this was my bad, however I think the implementation is quite confusing. I.e., how you would reach the code for each of these is not very clear from the docs/types.

let leaderboardIndex = await wowClient.pvpSeason({
  id: 36,
  resource: "leaderboard",
})
let leaderboard = await wowClient.pvpSeason({
  id: 36,
  bracket: "shuffle-demonhunter-havoc",
  resource: "leaderboard",
})
let season = await wowClient.pvpSeason({
  id: 36,
})
let seasonRewards = await wowClient.pvpSeason({
  id: 36,
  resource: "reward",
})

from blizzard.js.

benweier avatar benweier commented on May 19, 2024

I agree it's not as clear as it could be and there's an opportunity here to improve the documentation

from blizzard.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.