drop_pops() not actually dropping pops about simple_pop_stats HOT 3 OPEN

So, after closer examination, I don't believe this is a script issue, but rather reflects a more interesting conundrum surrounding the use of the "region" being appended to the end of the collection name in step 2 (eg. append_region =TRUE in fix_pop_names(). This is a useful feature - allows for quickly identifying regional or CU groupings when organizing a dendrogram - but means that the "drop_pops" file needs to also include the region for a match to be made.

Three potential fixes:

1. Just leave it as is, and make this clear in the README? You could probably do this region appending easily enough from the "StockCodes" file created by prepare_stockcode_file() in step 2, in excel (or even directly in that script). Excel would be =B2&"_"&C2 then dragging that down. In R, this could be a fourth column that is output to this StockCode file, such as df$collection_repunit <- paste(df$collection, df$repunit, sep="_")

2. Allow for a string partial match. This I don't like, because there will be situations where you might want to drop "Chilliwack" but not "Chilliwack-summer". We would have to rely on the string being unique, which will be dangerous (99.9% successful, but that 0.1 will cause problems".

3. Append the region to the filter file, by new script?

4. ... Suggestions?

from simple_pop_stats.

@erondeau, may not be the best solution but if I did the fix pop without appending then applied the drop pop filter and went back to fix pop script and did the appending to region?

from simple_pop_stats.

This is a good idea - although it didn't work as currently written. Still, some version of Janine's suggestion is likely best, and can be written into the Readme. I will follow-up next week on how to implement it!

from simple_pop_stats.