Comments (9)
Fixed by #26, only took two years!
from peity.
Yes! Absolutely! In fact it should be the default for line and bar charts.
from peity.
Thanks for the quick reply. I'm not sure if you mean it already should be the default, or you think that the default should change to 100%. In the docs here (http://benpickles.github.com/peity/) the default width for line and bar is 32px.
from peity.
I would also love to be able to set percent width.
Many sites are responsively designed these days (including mine) so setting a percent rather than pixel width would allow the peity.js charts to resize depending on browser width.
thanks @benpickles for making such a great plugin!
from peity.
Percentage width would be very useful, particularly as I use these graphs above & underneath other content which has a variable width
from peity.
I think this Stackoverflow (SO) thread answer by @6052 is the answer we are looking for.
It seems the key thing is that there are two sets of height/widths for the canvas, a JS and a CSS one.
The crappy solution is to set the canvas CSS width as a % while leaving the canvas.width and canvas.height in pixels. An example of this is shown in this JSFiddle. You'll notice that the canvas does resize when you change the browser width, its just that canvas is blurry when the browser width gets big enough.
The improvement on this seems to be to only specify the canvas.width when you know the browser width. So one implemenation could be getting the window.innerWidth
and taking some pixel percentage of that?
Perhaps check out the SO thread and give your thoughts?
from peity.
FYI I'm thinking about this but haven't quite come to a final decision yet. It seems sensible to support percentage dimensions but I have to give some further thought to the implications.
from peity.
thanks, yeah it is not as simple as I originally thought...
from peity.
I have a proof of concept for using percentage dimensions, there's more work to do and I've only tried it with line charts but it looks promising - #26.
from peity.
Related Issues (20)
- Change data-value to label
- data-value not working with "bar"
- Any react-native port?
- Required Two different color in Line chart HOT 1
- points calculated wrong in DataTables cell HOT 2
- can it have lables HOT 1
- Add ability to use CSS classes on SVG charts HOT 2
- jQuery version and Peity version always conflict HOT 2
- innerHTML to Span HOT 6
- Adding composer.json and submitting to packagist HOT 4
- Smooth animate pie chart on update HOT 2
- when using with bootstrap HOT 4
- This project should be renamed to piety HOT 1
- Charting fractional values HOT 1
- Add a mouseover to view data HOT 1
- Stacked bar HOT 1
- Any way to know if the numerator is greater than the denominator in a pie with delimiter /? HOT 2
- Semicircle donuts?
- show percentage in center donut HOT 1
- Further custom styling
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peity.