Expose Redis connection pool about goworker HOT 5 OPEN

In issue #11, I tried to extend the lib with an Enqueue method, but there is a problem with the pool management:
I cannot guess when I can close it easily, because the original code close the pool when there is no more worker.
In fact I had to disable this but I cannot sleep anymore since then :-)

Sharing a pool is a very important feature I think because you want to be able to define the number of available connections for the whole application, not per library.

The problem should be solved by doing the opposite, there should be a way to pass a connection pool to Goworker. That the role of the application to manage it, not from the library.

What do you think?

from goworker.

@oliamb injecting your own redis pool sound great as long as it implements an interface that guarantees the operations goworker expects, exist in the custom worker pool.

There is however an inherent risk here sharing the pool between goworker and the client app/workers in that either one could in theory monopolise the redis connections and DoS the other. For this reason it may be better to keep them separate.

from goworker.

First, I should state that the actual behavior should be kept for the sake of simplicity. Passing the pool should be considered optional. From there, that's up to the developer to decide whether he trust his workers enough to share a common pool or if he wants to have different pools for different parts.

• DoS: yes, true. I had this concern about the Enqueue func. It seems that at least goworker do it right by pushing the connection back to the pool before processing the job, so even a pool containing one connection will not run into some kind of dead lock ; as long as the job also push the connection back as well.
• Implementing the right interface: true again, this is a somewhat hard dependency on redigo and code.google.com/p/vitess/go/pools, but probably it is ok?

from goworker.

@oliamb so you'd only be able to inject a vitess/redigo pool for now?

That's fine as it changes less code.

If someone needs to use another pool/redis client the option still remains to insert an interface into goworker that all pools need to conform to. This can be built when the need arises though.

from goworker.

That makes sense to me. I'd be fine with making my own redigo pool and then giving that to goworker to use.

from goworker.