Code Monkey home page Code Monkey logo

Comments (8)

benkaiser avatar benkaiser commented on July 17, 2024

@Eaterofcode see the new instructions.

Do you know if there is a way to update the repo using this method?
Currently the update instructions would have been to git pull origin master.

from stretto.

the-eater avatar the-eater commented on July 17, 2024

npm update https://github.com/benkaiser/node-music-player/archive/master.tar.gz

Btw great work on the player I tried once too,

Isn't as beautiful as yours tho ;) I actually restarted that project but bigger :)

(dont listen to the music listed there on the image, its speedcore, Im sorta in hardmusic)

from stretto.

benkaiser avatar benkaiser commented on July 17, 2024

Thanks, I will make the amendments about updating later :) maybe tomorrow

Nice job. Are you making it open source or?

Did you run into any browser performance issues with your player when loading so many songs into the DOM?

My UI looks good because I took a lot of ideas from the previous music service I was using. I am planning on making a mobile version to with a mobile url that works off the same javascript but with different templates, so that it is usable and looks good on a phone.

Have you tried mine much? I added search functionality today which makes it a bit more usable as a daily driver :)

from stretto.

the-eater avatar the-eater commented on July 17, 2024

I dont know yet since that is a really big project, I would but I dont know if the co-owner is okay with it :)

and no, because I didn't load any songs in the DOM, I just made a list, and when a user clicks on a song it changes the main audio element with the song id :)

aaah sounds awesome I used bootstrap in the old one and I have a designer working on the new one ;)

I just tried, and got some bugs its trying to stat C:\C:[path] :o

btw the scanning is slow :(

from stretto.

benkaiser avatar benkaiser commented on July 17, 2024

Okays fair enough.

I meant like loading the table into the DOM (not the audio itself).

Yeh you can try fix those path issues, I don't use windows as any of my machines except for gaming (all running Linux here), but if you want to give it a shot I would accept a pull-request that was well-formatted. I have added a hint to that issue that might help you.

Yeh I will try speed up scanning, see my comment on leetrevails's repo.

from stretto.

the-eater avatar the-eater commented on July 17, 2024

oh table, I don't use tables, tables always seem to be bad practice to me and afaik there is also over head in the calculations of the sizes of each cell, I used a <lu> :) which is a lot more lightweight.

from stretto.

the-eater avatar the-eater commented on July 17, 2024

oh I actually used a table? o: still think a ul is faster tho lemme look at the CSS

from stretto.

the-eater avatar the-eater commented on July 17, 2024

update: img give some big lag issues. removing them results in smooth scrolling. They not that important so I dont think its a problem removing them

from stretto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.