Traversing comment nodes. about ast-types HOT 3 CLOSED

Ah, the problem is that .comments is a "hidden" field of the Node type, due to the true argument here:

def("Node")
    .bases("Printable")
    .field("type", isString)
    .field("comments", or(
        [def("Comment")],
        null
    ), defaults["null"], true);

I'm tempted to un-hide it, because I doubt anything would break. In order for code that previously used types.visit to be broken by this change, the visitor would have to have a visitPrintable method and also not be prepared to handle comments, which seems unlikely.

from ast-types.

On the other hand, maybe a safer approach would be to modify the visitor code so that it visits .comments if present, in addition to the fields given by types.getFieldNames.

from ast-types.

Wow, thank you!
Blown away by this api man. Seriously great.

from ast-types.