Comments (7)
Do you mean return false;
(and not calling this.traverse
), which would not descent further at that node? Or do you want to completely stop traversing the AST?
from ast-types.
Yes, i mean to completely stop traversing
from ast-types.
Yep, throwing an exception is currently the best way to abort not just the current subtree (return false
for that) but all remaining nodes. I like the semantics of throwing an exception, because you could potentially catch it in an ancestor visitor if you wanted to.
I'm curious if your hesitance to use exceptions has more to do with performance, or the burden of writing your own try
-catch
block to intercept the exception. If the latter, I'd be happy to consider a special exception type that could be caught in the top-level PathVisitor.prototype.visit
method.
from ast-types.
Published support for PathVisitor.prototype.abort
just now (v0.6.13): https://www.npmjs.com/package/ast-types.
Thanks for the idea!
from ast-types.
Wow, that's great! Thank you a lot, that really simplifies things in two upcoming projects - ast-test and ast-replace.
from ast-types.
Nice, I'm glad to hear it, and looking forward to seeing what you do with those projects :)
from ast-types.
Yes, here they are: ast-replace, ast-test.
from ast-types.
Related Issues (20)
- ArrowFunctionExpression fails to check arrow functions without body and the type is also wrong HOT 3
- Decorator visitor can't work
- [Flow] did not recognize object of type "PropertyDefinition" HOT 3
- core.ts does not test whether BigInt exists HOT 4
- ast-types no longer published on npmjs.com? HOT 4
- npm install fails due to conflicting peer dependency
- `quote: 'single'` is broken in 0.15.2
- `b.functionExpression.from(functionDeclaration)` is failing on Windows HOT 1
- [Proposal] we should provide a function to build a fork with defs extracted from @babel/types HOT 4
- Jay-Jones-TOKEN_693697a3f04163a6e53f66fa9dbf0cd3e8a9d6face40e7e2483ff106fd22d9afeac596df74ae93d22dfcf4ee978cc6e2782983287695126f18c7ae1c64903e85e71e9fc814ac7d83bf74445e733a98db281d631362ddcc2c1a8228c379d98cbf447c28c9d8405c5ef7e68927f3bd926e722b5a7de234da85d3141bc7b185a1fe"/>true HOT 1
- No support for PrivateIdentifier? HOT 1
- node.extra for `RegExpLiteral` appears to produce the wrong value
- Can we add "TSSatisfiesExpression" to src/def/typescript.ts HOT 1
- ClassDeclaration type is missing decorators HOT 1
- Does `TSTypeParameter.name` need to be all of `IdentifierKind` types?
- Wrong structure of TSFunctionType node HOT 1
- partial visit HOT 1
- Missing catch binding breaks scope API
- TSTypeOperatorBuilder interface call signature should accept a typeAnnotation parameter
- Type errors with TypeScript 5.4+
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ast-types.