Code Monkey home page Code Monkey logo

Comments (7)

fkling avatar fkling commented on May 15, 2024

Do you mean return false; (and not calling this.traverse), which would not descent further at that node? Or do you want to completely stop traversing the AST?

from ast-types.

dy avatar dy commented on May 15, 2024

Yes, i mean to completely stop traversing

from ast-types.

benjamn avatar benjamn commented on May 15, 2024

Yep, throwing an exception is currently the best way to abort not just the current subtree (return false for that) but all remaining nodes. I like the semantics of throwing an exception, because you could potentially catch it in an ancestor visitor if you wanted to.

I'm curious if your hesitance to use exceptions has more to do with performance, or the burden of writing your own try-catch block to intercept the exception. If the latter, I'd be happy to consider a special exception type that could be caught in the top-level PathVisitor.prototype.visit method.

from ast-types.

benjamn avatar benjamn commented on May 15, 2024

Published support for PathVisitor.prototype.abort just now (v0.6.13): https://www.npmjs.com/package/ast-types.

Thanks for the idea!

from ast-types.

dy avatar dy commented on May 15, 2024

Wow, that's great! Thank you a lot, that really simplifies things in two upcoming projects - ast-test and ast-replace.

from ast-types.

benjamn avatar benjamn commented on May 15, 2024

Nice, I'm glad to hear it, and looking forward to seeing what you do with those projects :)

from ast-types.

dy avatar dy commented on May 15, 2024

Yes, here they are: ast-replace, ast-test.

from ast-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.