Improved class declaration/creation/instanciation support about intellij-luanalysis HOT 3 OPEN

Rather than doing this auto-magically, I'd prefer a more explicit approach e.g.

---@class ServiceDefinition
---@overload ServiceDefinition:new

That way the one project can mix and match instantiation schemes, and if you're publishing a library, people can just use your library as is without needing to change Luanalysis preferences.

This actually touches a little bit on #5... Will comment more there.

from intellij-luanalysis.

from intellij-luanalysis.

(sorry for the double comment, I cleaned that up, the first one got posted too early...)

Any news ? :)

I'm asking because I'm still facing difficulties getting everything to work correctly for some more "complex" annotations:

(ignore that dummy Class function, that's just for the sake of this screenshot)

As you can see here, for some reason the tmp variable isn't typed as a MyClass, even though everything else seems OK:

• the private fields are correctly typed if I ctrl-hover them in any class method. (thanks to the first part of the MyClass @type annotation)
• the constructor is correctly recognized (thanks to the second part of the MyClass @type annotation)

BTW, I did try the following, but that didn't solve it completely (to be clear: it made the return value typed correctly, but the constructor parameters became unknown because MyClass doesn't have the alternate function type that provided the info anymore)

---@class MyClass
---@overload fun(id:number, name:string, options:table<string,any>|nil):MyClass

Is this a bug somehow, or am I missing something? Or is it something that's known to be non-working right now and that would be handled later (with something like what you mentioned in the earlier comments)

Thanks!

Edit :
I found a way to make it work, but unfortunately the actual Lua code changes, and that's a no-no:
I guess the following is the only way to "dual-type" a class correctly.

---@class MyClass
---@overload fun(id:number, name:string, options:table<string,any>|nil):MyClass
---@field private id number
---@field private name string
---@field private options table<string,any>
local MyClass

---@type MyClass | fun(id:number, name:string, options:table<string,any>|nil):MyClass
local MyClass = Class()

[...]

from intellij-luanalysis.