Can't set up multiple JedisBundles in the same DropWizard application about droptools HOT 9 OPEN

It isn't currently supported, but there's no deeper reason why not. I never had the need, and neither has anyone else (at least, nobody who wanted it enough to let me know, until now!). It's a reasonable thing to want to do.

I think your hunch is correct - "redis" is indeed hardcoded for metrics and healthchecks, which won't work for multiple connections. Connection names could follow, e.g. instead of "redis.connections.idle" we could have "redis.readonly.connections.idle".

The bigger question for me would be the API to choose which of the connections you want to inject into resource methods. I haven't used Dropwizard for a long time now; my knowledge is mostly for Jersey 1.x, which hasn't been in use in DW since like 2014, I think. I'd appreciate any ideas you have.

Say you had "readonly" and "leader" connections. Simple @Context annotations are not sufficient to distinguish between them. What would the right API look like?

from droptools.

Hmm, good question. We use Guice injection in our codebase, so we haven't had the need to use @Context. I'll have to think about that some more. Thanks for the quick response!

from droptools.

I'm not very familiar with HK2, but I wonder if this could be achieved by using named injection. I don't know if @Named can be used with @Context. If so, it should be easy to bind two different JedisPools by using .named(...) in the binding. Thoughts?

from droptools.

@vasukisesh Are you using this project along with Guice injection? How did you manage to be able to inject Jedis instances not using @Context annotation? Thanks!

from droptools.

When you're setting up your Guice modules, give one of them the pool object from your JedisBundle implementation, and have it bind the pool as a singleton instance. Lifecycle issues makes this a bit tricky, since you won't have the pool until your application's run method (i.e. not during initialization).

from droptools.

@benjamin-bader But, then you have to get resources from the pool as needed, right? Using a try-with resources every time or am I missing something?

from droptools.

Basically, unless you can find a way to (for example) configure request-scoped injection such that a connection is obtained from the pool, then destroyed when the scope ends. I haven't used guice personally in a very long time, so I don't know how to do this or even if it is possible.

Generally, try-with-resources isn't too burdensome, and as your application grows its weight will be negligible. @Context-injection is really only appropriate for the smallest of microservices; usually, your request handler isn't going to be aware of things like redis connections. That's usually the job of a Repository of some sort.

from droptools.

Sorry for the delay in replying, but I've been on vacation. Yes, we basically did what @benjamin-bader has suggested above. We pass the JedisBundle reference into the constructor of our Guice module and then bind JedisPool.class to the pool from the bundle in the module's configure method by which point the pool is available. Using the dropwizard-guicey library helps get around much of the lifecycle issues.

As for your second question, again @benjamin-bader is correct. You should be using try-with-resources every time you need a connection the pool. That is the preferred method of using Jedis anyway. You can use a RequestScoped bean to create your connection but I wouldn't recommend it. We have a layer of abstraction in our service that handles all the Redis communication and it "hides" the connection management from the caller.

from droptools.

@vasukisesh Thanks for your response. Yeah, the other way around didn't seem very well designed. So, I took your approach.

@benjamin-bader Thanks for your help.

from droptools.