Code Monkey home page Code Monkey logo

Comments (3)

JoshuaMeyers avatar JoshuaMeyers commented on September 6, 2024

Hey @LivC182, thanks for your interest in our code! Yes isomericSmiles is set to False although this name can be somewhat misleading since it only affects stereoisomers (see rdkit doc). So for example this wouldn't preclude the differentiation between pentane and isopentane since these have different connectivities.

However, your point is valid in the more specific case of stereochemistry. This is an area for future work. I can only speculate on the authors' reason for excluding stereochemistry:

(a) for simplification since @@ and @ encode stereochemistry relatively (different canonicalization can flip this sign), and therefore does not encode the absolute (R/S) stereochemistry of the molecule. Therefore its not good enough to merely encode single and double @ individually)

(b) because many scoring functions (such as Morgan fingerprints which are used for the rediscovery and similarity benchmarks) also ignore stereochemistry by default

from guacamol.

LivC193 avatar LivC193 commented on September 6, 2024

HI @JoshuaMeyers,
I completely agree with all your points. I just wanted to make sure if isomers (except structural ones) are taken into account. If you have carbohydrate entries in your dataset not taking isomers into account might be problematic.

galactose_smiles = ''C([C@@H]1[C@@H]([C@@H]([C@H]([C@@H](O1)O)O)O)O)O''
glucose_smiles="C([C@@H]1[C@H]([C@@H]([C@H]([C@H](O1)O)O)O)O)O'"
gal = Chem.MolFromSmiles(galactose_smiles)
glc = Chem.MolFromSmiles(glucose_smiles)
print(Chem.MolToSmiles(gal, isomericSmiles=False))
'OCC1OC(O)C(O)C(O)C1O'
print(Chem.MolToSmiles(glc, isomericSmiles=False))
'OCC1OC(O)C(O)C(O)C1O'

from guacamol.

JoshuaMeyers avatar JoshuaMeyers commented on September 6, 2024

Yes this is true. In the GuacaMol v1 SMILES training dataset, there are in fact 45 occurrences of the SMILES you give as an example (as substrings of larger molecules). Thanks for highlighting this case.

from guacamol.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.