onChange event not called when selectedValue === index value about react-responsive-select HOT 8 CLOSED

Hi @benbowes, thanks for looking at this.

Here is an example you can test with:

         options={[
            { text: 'ALL', value: 'ALL' },
            { text: 'This option breaks', value: 1, markup: <span>warning</span> },
            { text: 'This will work', value: 2 }
          ]}

1. Select value 1 option.
2. then unselect option 1. It will stay on value 1 and the onChange will not be fired if selecting another option.

from react-responsive-select.

Thanks @litzenberger, will check this out.

from react-responsive-select.

@litzenberger any chance you could show me the configuration you used to uncover the bug?

from react-responsive-select.

Hi @litzenberger ,

The problem seems to be caused by option.value being a number, try changing it to a string.

When I checked the the browser console for the above config, it printed

Warning: Failed prop type: Invalid prop options[1].value of type number supplied to SingleSelect, expected string

from react-responsive-select.

Yes, changing it to a string will work but so does padding the integer so that index will never match the selectedValue. Is there a reason value has to be a string?

I was using multiselect and do not see a warning in console.

Thanks!

from react-responsive-select.

The multiselect mode should give a warning about the string prop not being a string. That needs to be sorted.

I'd like to know why do you think it shouldn't be a string? What benefits may present themselves by changing the interface?

from react-responsive-select.

Yeah, no benfiit just something I missed when implemeting the component.

I'll go ahead and close this issue.

Thanks again.

from react-responsive-select.

Cheers for finding the props bug. That needs to be fixed. 👍

from react-responsive-select.