Code Monkey home page Code Monkey logo

Comments (7)

benbowes avatar benbowes commented on June 15, 2024 1

I've added a disabled checkbox to this codepen https://codepen.io/benbowes/pen/baKoBQ?editors=0010 It shows up the issue. I'll look into it

from react-responsive-select.

benbowes avatar benbowes commented on June 15, 2024

Hi @thedistricts I understand what you are talking about. Did you have any thoughts on how to address this?

from react-responsive-select.

benbowes avatar benbowes commented on June 15, 2024

Whilst working on this I realise that the disabled scenario is not reading out well for screen readers. I will sort this out as well. I expect to be done in a few days.

Let me know if you'd like to review the PR.

from react-responsive-select.

benbowes avatar benbowes commented on June 15, 2024

#58

I will move demo/src/index.js to be the new controlled example on codepen.

from react-responsive-select.

benbowes avatar benbowes commented on June 15, 2024

3.0.3 now released to npm including work done in #58, and the controlled example on (codepen controlled example)[https://codepen.io/benbowes/pen/baKoBQ?editors=0010] looks to be working as I had expected.

I did keep the component focusable, but added an aria-disabled attribute to call out it's inability to be interacted with.

Gonna close this issue for now. Let me know if anything is outstanding.

Thanks heaps for bringing this up @thedistricts 👍

from react-responsive-select.

thedistricts avatar thedistricts commented on June 15, 2024

Amazing! Thanks for the super quick turn around on this @benbowes

from react-responsive-select.

benbowes avatar benbowes commented on June 15, 2024

Cheers 👍

from react-responsive-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.