Comments (1)
Hey, I saw the merged PR and I have a few follow up questions:
- since it has been merged, shouldn't this ticket be closed (if the problem is now solved)?
- looking at the code of the PR, I disagree a bit on how it works:
- In my understanding,
PHPUnitExceptionStringer->supportsException
should have prevented the original problem from happening, so I would recommend looking into why it wasn't - The code of
PHPUnitExceptionStringer->stringException
is now a bit messier.. "if class exists return x; if class does not exist return z; else it must exist and therefore return y..", IMHO this would be clearer and more readable:
It now also exposes the original flaw, which the patch didn't fix adequately IMO.switch (true) { case class_exists('PHPUnit\\Util\\ThrowableToStringMapper'): return trim(\PHPUnit\Util\ThrowableToStringMapper::map($exception)); case class_exists('PHPUnit\\Framework\\TestFailure'): // PHPUnit assertion exceptions do not include expected / observed info in their // messages, but expect the test listeners to format that info like the following // (see e.g. PHPUnit_TextUI_ResultPrinter::printDefectTrace) return trim(\PHPUnit\Framework\TestFailure::exceptionToString($exception)); case class_exists('PHPUnit_Framework_TestFailure'): return trim(\PHPUnit_Framework_TestFailure::exceptionToString($exception)); default: // TODO this should also be somehow handled }
- In my understanding,
- Shouldn't
PHPUnitExceptionStringer->supportsException
also be updated to handle the new formatter?
from behat.
Related Issues (20)
- SSL certificate problem: unable to get local issuer certificate HOT 3
- Symfony 7 support HOT 1
- [bug] jUnit formatter returns time as int but should use float HOT 1
- [Bug] jUnit formatter produces empty testsuite names, it could use feature file as suite name HOT 5
- Parallelization of tests HOT 1
- SigintController does not check for both pcntl-functions used in execute() HOT 6
- [Bug?] Reruns of Scenario outlines lead to potentially confusing scenario names HOT 2
- Exception thrown when test fails with junit formatter HOT 1
- Documentation for StepEvent hooks in Behat 3.0 HOT 8
- Add support for Rule keyword (Gherkin 6) HOT 2
- Skip or improve translation process
- how to have a context/class per feature ?
- New release for Symfony 7 HOT 8
- Can't use %paths.base% inside extensions: Failed opening required '%paths.base%' HOT 2
- phar is broken for the 3.14.0 release HOT 4
- Extension for auto naming parameters HOT 2
- Better documentation for `filters` key
- Is behat dead? HOT 2
- Progress vs pretty output -- Progress is WAY slower!
- getScenario() has to return a Scenario but returns an ExampleNode so the getTitle() function didn't works as expected HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from behat.