Comments (7)
By the way, https://deps.rs/repo/github/stanislav-tkach/os_info link is reported as "404 - Not Found", though the link is OK.
I could reproduce this locally. The problem is that the link returns 404 on a HEAD request:
curl https://deps.rs/repo/github/stanislav-tkach/os_info --head
HTTP/2 404
date: Wed, 11 Nov 2020 19:56:48 GMT
content-length: 0
set-cookie: __cfduid=d281a6e206188bd8b96d642babfad5d351605124607; expires=Fri, 11-Dec-20 19:56:47 GMT; path=/; domain=.deps.rs; HttpOnly; SameSite=Lax; Secure
cf-cache-status: DYNAMIC
cf-request-id: 065a7ae74500001181a6b41000000001
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report?s=QIYT4KZwhKEwiYRoDYKTddqGGSlYfKVvq9mpHbvbN40O6kbRt8EuawLsOKx2olFD5%2BgXPeNutuXTiqR%2FgEDW%2Bm8rzNapsECb"}],"group":"cf-nel","max_age":604800}
nel: {"report_to":"cf-nel","max_age":604800}
server: cloudflare
cf-ray: 5f0a941ed8771181-MIA
This is not an expected behavoir... though I might try a bit harder here and send another GET request which would give me a 200 then. I started with HEAD requests because they are so much cheaper... but yea, seems like there is a lot of unusual stuff out there...
Describe the bug
In some cases the resulting "the following links could not be resolved" list includes valid links. For example:The following links could not be resolved: ./os_info/README.md (6, 87) => https://deps.rs/repo/github/stanislav-tkach/os_info. ./cli/README.md (6, 87) => https://deps.rs/repo/github/stanislav-tkach/os_info. ./README.md (6, 87) => https://deps.rs/repo/github/stanislav-tkach/os_info. [ OK ] ./CHANGELOG.md (222, 10) => https://github.com/stanislav-tkach/os_info/compare/v0.7.0...v1.0. Result (90 links): OK 87 Skipped 0 Warnings 0 Errors 3
There are only three failures in the log above, but the list includes four links.
To Reproduce
Unfortunately I'm unable to create a minimal reproducible example, moreover this issue isn't reproduced locally. However, it is stably reproduced on CI. Perhaps the MLC github action can affect this somehow?Here are logs with and without debug output.
Expected behavior
I expect to see no "[ OK ]" links in the "the following links could not be resolved" section.Desktop (please complete the following information):
- OS: Ubuntu 20.04.1 LTS
- Browser Firefox 82.0 (64-bit)
- Version 0.13.11
This one is harder. I could not reproduce it locally, yet. :( I will try to find a solution as soon as I know how to debug this....
from mlc.
By the way, https://deps.rs/repo/github/stanislav-tkach/os_info link is reported as "404 - Not Found", though the link is OK.
This is now fixed with release v0.14.0.
from mlc.
Thanks for reporting. I will look into it. Do you use it in a public repo and can I see the failing/wrong checks?
from mlc.
My mistake: I was sure, that I included the links to the logs! Sorry for that.
Here is the output from CI with the --debug
flag: https://github.com/stanislav-tkach/os_info/runs/1338649624
And without it: https://github.com/stanislav-tkach/os_info/runs/1338626756
The repository is public too: stanislav-tkach/os_info#243
from mlc.
By the way, https://deps.rs/repo/github/stanislav-tkach/os_info link is reported as "404 - Not Found", though the link is OK.
from mlc.
This is now fixed with release v0.14.0.
Thanks!
from mlc.
can be closed?
from mlc.
Related Issues (20)
- Potential alternative/similar project: mdbook-linkcheck HOT 1
- (maybe) Support a `--secure-only` flag, that warns about http (vs https) links HOT 1
- Missing binaries for 0.15.x releases HOT 2
- Directory parameter is ignored if provided after an option HOT 5
- Support for ignore link list from a file HOT 3
- Allow specifying HTTP request parameters HOT 10
- Latest Docker images broken HOT 1
- Line and column wrong with windows typical line breaks
- Support reporting redirections HOT 2
- Format links in vs code console so that ctrl + left click opens the file at right location HOT 1
- First line separator is wrong on Windows HOT 1
- Use GitHub actions workflow commands
- Installation failed HOT 2
- Evaluate keeping compatibility with some not-so-old glibc HOT 7
- Option to check links in code blocks HOT 2
- Links with spaces in not parsed correctly HOT 1
- Support `ignore` or `disable` lines and blocks in checked files HOT 2
- Support reading ` .gitignore` if present to ignore paths HOT 2
- `.mlc.toml` options are not used HOT 11
- Mismatch between definition and access of `throttle` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mlc.