Code Monkey home page Code Monkey logo

Comments (8)

bebraw avatar bebraw commented on May 18, 2024

Can you try modifying hex extra? Here's rgb. Maybe there's some corner case missing.

from colorjoe.

simetin avatar simetin commented on May 18, 2024

I can try to take a look, but I really don't think that I'm skilled enough for that

from colorjoe.

bebraw avatar bebraw commented on May 18, 2024

@tchinou1 Any luck? Do you want me to have a look? If you can set up a standalone test case for me to study, that will help.

from colorjoe.

simetin avatar simetin commented on May 18, 2024

No I haven't been able to do anything. If you want to check, it would be very nice ! But I'm not sure to understand what you mean by a standalone test case.
Thanks !

from colorjoe.

bebraw avatar bebraw commented on May 18, 2024

@tchinou1 Just something to illustrate the issue. Do you see it at the online demo?

from colorjoe.

simetin avatar simetin commented on May 18, 2024

No, here is a page of my app: http://luxontower.com/app/colorpickerdemo.php

from colorjoe.

bebraw avatar bebraw commented on May 18, 2024

I got 2 problems when I try to manually enter a color. First, in the RGB field my cursor keep coming back to the end, I need to remplace it 2 times to be able to enter a color.

Confirmed. I think the hex input will need a little tweak to retain its position. It's going to get a little complicated depending on which browsers we want to support. Here's the basic idea: https://stackoverflow.com/questions/2897155/get-cursor-position-in-characters-within-a-text-input-field .

Second, in the Hex field when I enter the color there is a modification in the hex value and when I press close, it change to black.

This is a weird one. I cannot see the behavior in the official demo. Can you try to figure out how your setup differs from that? It looks like the value cycles (00000b -> 0000b0).

from colorjoe.

bebraw avatar bebraw commented on May 18, 2024

Third issue: Before opening the selector, we should probably do a cropping check against the window. I mean we should open at top of the input if it's going to crop. Otherwise it's going to be unusable for those lower inputs.

from colorjoe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.