Code Monkey home page Code Monkey logo

Comments (5)

philgyford avatar philgyford commented on August 16, 2024

One other thought - should it be possible to create duplicate OutgoingWebmentionStatus objects, like it is at the moment?

Maybe ensure that source_url and target_url are unique together (unless there's some reason that would break something else that I'm missing)?

While that wouldn't fix the cause of the problem, it would prevent the symptom of thousands of identical outgoing statuses building up in the DB.

from django-wm.

beatonma avatar beatonma commented on August 16, 2024

Hey,

If you are upgrading to 3.0.0 be aware that the migrations will delete and recreate the PendingIncomingWebmention and PendingOutgoingContent models which will also delete any existing instances of those models. If you want to keep them please don't upgrade yet and let me know - I will add a management command to transfer them between versions.

Sorry this took such a long time to get out - especially for this particularly broken issue, but also all the others you reported. Thanks again for raising them, and for providing such detailed reports. They should all now be fixed!

from django-wm.

philgyford avatar philgyford commented on August 16, 2024

Wow, that's a lot of work for 3.0.0, well done! Thank you so much for all that. I should be able to try it out in the next couple of days. I don't think there's much/anything I need to keep in the pending lists, or I can recreate one or two if necessary. I'll let you know how it goes.

from django-wm.

philgyford avatar philgyford commented on August 16, 2024

Just wanted to say I've upgraded to 3.0.0 and things seem to be working well. Thank you so much, again!

I had to run makemigrations for the model that used MentionableMixin, due to the understandable removal of that one field, but otherwise all was smooth.

One thought for a tweak - usually an app's templates are within an app-specific directory. So, rather than the templates being in django-wm/mentions/templates/ they'd be in django-wm/mentions/templates/mentions/. Then, if the end user wants to override a template, their overriding templates would live in a templates/mentions/ directory in their project, rather than rattling around loose in templates/.

from django-wm.

beatonma avatar beatonma commented on August 16, 2024

Oops, just noticed your comment about the template location just now - will fix in the next release.

from django-wm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.