title attribute used as type and does not resolve about json-schema-to-typescript HOT 9 CLOSED

@Speedy37 Can you take a look when you have a chance? Otherwise I can look later this week. Or if @simonschllng wants to give it a shot, go for it!

from json-schema-to-typescript.

Thanks for the quick response @Speedy37!

from json-schema-to-typescript.

@simonschllng Looking at your usage in #19, you're missing the required filePath parameter when calling compile(). I've made this parameter optional in #20, and published it as 2.0.1.

If you install the latest and try again it will work fine for your use case.

Ironically, using either TS or a JSON-Schema for the json-schema-to-ts API would have prevented this improper use :)

from json-schema-to-typescript.

This seems like a bug to me. @Speedy37 What was your intention here?

from json-schema-to-typescript.

yes it is a bug,
the title was supposed to be used as type name nothing more.

from json-schema-to-typescript.

it should generate:

interface MyInterface {
  users?: UserIdArray;
}
type UserIdArray = string[];

from json-schema-to-typescript.

@bcherny, it still isn't working as of version 1.2.2.

I had to build the dist/index.js by doing:

cd node_modules/json-schema-to-typescript/
npm install
gulp dist

Now it works.

But actually: The title in JSON Schema is for informative purpose and non-functional. It would be more logical to just ignore it.

from json-schema-to-typescript.

Please upgrade to 2.0.0.

from json-schema-to-typescript.

2.0.0 did fail on my schema with

path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.resolve (path.js:1148:7)
    at new Compiler (/.../node_modules/json-schema-to-typescript/dist/index.js:279:27)
    at Object.compile (/.../node_modules/json-schema-to-typescript/dist/index.js:557:12)

I will try to solve this later...

from json-schema-to-typescript.