Code Monkey home page Code Monkey logo

Comments (3)

jab avatar jab commented on July 28, 2024 1

str.startswith optionally takes a tuple of strings to try. Better to write the above as not any(repr(ch).startswith(("'\\x", "'\\u")) for ch in s)

from bullet.

a-luna avatar a-luna commented on July 28, 2024

A response to the stackoverflow post, Test if a python string is printable, provides a clever way to check for non-printable characters:

def is_printable(s):
    return not any(repr(ch).startswith("'\\x") or repr(ch).startswith("'\\u") for ch in s)

Replacing the check in utils.py to use this function would allow any utf-8 printable input to be used:

if is_printable(c):
    return c
else:
    return UNDEFINED_KEY

I'll create a PR with this change, hopefully it will be accepted since allowing utf-8 input should be a requirement (IMO).

from bullet.

a-luna avatar a-luna commented on July 28, 2024

I had no idea that you could provide a tuple to startswith, thank you for pointing that out! The updated version will be in the PR.

from bullet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.