Comments (9)
bblanchon
commented on May 28, 2024
Hi @johnyradio,
I respect your opinion, but I believe that clean code mustn't contain any traces; that's why I remove all the traces before committing.
Traces are just a diagnostic tool that I use temporarily.
How does this request differ from #7?
Best regards,
Benoit
from arduinotrace.
johnyradio
commented on May 28, 2024
Hi Benoit
**First concern** is reducing effort, and eliminating duplication of effort.
In your video, you're duplicating effort. With your traces in place, you
applied the bug-fix.
Then in order to remove the traces, you revert. Reverting ALSO removes
your bug-fix.
Then you reapplied the same bug-fix a SECOND TIME. That's duplication of
effort.
Ideally, you can find a way to remove the traces without removing the
bug-fix.
I see a few solutions:
- a simple manual search-and-replace, which replaces all the traces with
nothing. If possible, include the linefeed in the search.
- a macro which automates the same search-and-replace
Thx!
from arduinotrace.
johnyradio
commented on May 28, 2024
Second issue is: What if the programmer wants to COMPILE without the
traces, but KEEP using the traces for debugging purposes? Ideas:
-
search-and-replace to a NEW TEMPORARY FILE, and compile that new file.
(Don't even need to save it to disk). -
a pre-compiler which strips out the traces before compiling.
Ideally, Always compile without traces.
Cheers!
from arduinotrace.
bblanchon
commented on May 28, 2024
As I said on #7, you can define ARDUINOTRACE_ENABLE to 0.
from arduinotrace.
johnyradio
commented on May 28, 2024
ARDUINOTRACE_ENABLE to 0 will compile without traces?
from arduinotrace.
bblanchon
commented on May 28, 2024
Exactly.
from arduinotrace.
johnyradio
commented on May 28, 2024
Then why did you revert, in the video?
thx
from arduinotrace.
bblanchon
commented on May 28, 2024
As I already told you, I believe that clean code mustn't contain any debug code.
Traces are just a temporary diagnostic tool.
from arduinotrace.
johnyradio
commented on May 28, 2024
In your video, you did the following:
- added trace code
- applied the fix
- reverted
- re-applied the same fix that you did in Step #2, above.
Correct?
from arduinotrace.
Related Issues (10)
- Alternative serial port
- Option to disable all traces at once HOT 2
- Adding options to configure the output HOT 4
- Typo on internal macro HOT 1
- Adding a feature to define printable enums HOT 1
- Request: Compile without removing traces HOT 1
- Request to add break command HOT 3
- Request NO_PATH option HOT 1
- [question/suggestion] can print stack backtraces?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arduinotrace.