font-lock-preprocessor-face color about solarized-emacs HOT 7 CLOSED

Too much red on that screenshot, IMAO.

from solarized-emacs.

At the moment, red is never used in the 'normal' syntax highlighting scheme. Is it a matter of personal preferences or is there a standard way to attribute colors to font-locks?

from solarized-emacs.

I have tried in several rounds reducing the overall "dramatic" looks of this theme. I generally avoid red and orange for anything but warnings/errors

from solarized-emacs.

@arranger1044 : one of the main reasons I like solarized so much is because its relaxing effect that facilitates concentration. Using strident colors like red goes against that. The strident colors shall be reserved for "urgent" and "critical" elements.

Just my personal opinion.

from solarized-emacs.

@oscarfv I can agree on the misuse of 'strident' colors like red that shall better be used for warnings and errors, but my main point was that the flatness given to highlighted code (at least my c++) is caused by too many faces set to the same color: blue. Maybe it is less evident in other languages or it is just me not to stand it : )

from solarized-emacs.

I work on C++ too and blueish colors are not so prevalent: elements preceding double colon (namespaces, class names) function names and function args (both on function declarations), variable definitions and preprocessor elements.

What I see on my C++ code is a lot of elements on default or similar face, then yellowish (keywords), oranges (types), greenish (strings) and finally blueish. Of course it depends on the type of code you look at. It is not the same a header file chock-full of declarations than a .cpp file with long code sequences.

Your original message makes me think that you have quite a few preprocessor directives.

from solarized-emacs.

I have several #ifdef macros in my code but I suppose that even without them I would have differentiated the faces using blue. In the end my initial question seems to be answered : )

from solarized-emacs.