Code Monkey home page Code Monkey logo

Comments (21)

swsnr avatar swsnr commented on August 18, 2024

To clarify: Variable pitch is ok, as is the scaling of the headers.

However, the scaling should definitely be reduced. 1.3 is quite enough for level 1 heading.

Headings of level 5 and above should definitely not be scaled. Most (if not all) exporters do not consider these headings as titles, and export them as plain lists. Hence, scaling headers of these levels conveys a wrong impression to the user.

The lack of scaling on the TODO tag however is a real showstopper. This tag is at least as important as the title itself, and must have the same size at least. If that can't be done, the headers should better not be scaled at all.

from solarized-emacs.

swsnr avatar swsnr commented on August 18, 2024

Also regarding the scaling: A level 1 heading is currently larger and stands out more than the document title itself, which doesn't really account for the document structure…

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

I have tested it in two oses with recent emacs24's and a couple of different fonts a month or so.
This is how it looks in my default environment:

I have different than default task state colors which make that less of a problem...

My fonts are

(set-face-attribute 'default nil :font "PragmataPro-11.8")
(set-face-attribute 'fixed-pitch nil :font "PragmataPro-11.8")
(set-face-attribute 'variable-pitch nil :font "Pt Sans-11")

screenshot-2013-08-29_12-53-24_1272x1369

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

I'm not sure how to actually test a emacs theme other than just using changes myself for a while ( https://github.com/thomasf/dotfiles-thomasf-emacs/blob/master/emacs.d/lisp/my-solarized.el ) and if i don't see a problem just throw it out there to get reactions.

I guess everyone is free to use whichever revision they feel comfortable with.

from solarized-emacs.

swsnr avatar swsnr commented on August 18, 2024

Indeed, your Org file looks way better than mine, but I presume that you heavily customized Org to achieve this appearance. I am particularly interested in how you customized the heading markers. Would you mind to share the corresponding parts of your init.el?

However, you should not make a customized Org the baseline of your theme changes. You cannot expect any user of this to share your Org mode modifications and font preferences, so please, please test your modifications with the default Org task colors and some less exotic fonts (the DejaVu family would do well) before pushing them.

As for this specific issue, I understand that I should really customize my variable pitch face (shame on me that I didn't yet), but the height of the title is still less than optimal.

Please, please reduce the first level to 1.3, and use the standard height for level 5 and above.

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

I'll make sure that we dont use larger than 1.3 anywhere.. I see that I'm using a smaller variable-pitch size by default..

from solarized-emacs.

swsnr avatar swsnr commented on August 18, 2024

Thank you :)

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

the header bullets are org-bullets which is in org mode contrib since v8

from solarized-emacs.

swsnr avatar swsnr commented on August 18, 2024

@thomasf Nice :)

from solarized-emacs.

mboes avatar mboes commented on August 18, 2024

I also take issue with the scaling of org headers. Is it possible to turn this off somehow? Just calling custom-theme-set-faces in my init.el file doesn't work.

from solarized-emacs.

oscarfv avatar oscarfv commented on August 18, 2024

Mathieu Boespflug [email protected] writes:

I also take issue with the scaling of org headers. Is it possible to
turn this off somehow?

+1

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

i'll make it a customizable option soon. this will probably disable all font sizing everywhere, I would guess that you want that as well?

from solarized-emacs.

mboes avatar mboes commented on August 18, 2024

@thomasf indeed, such an option would be excellent. :)

from solarized-emacs.

oscarfv avatar oscarfv commented on August 18, 2024

Mathieu Boespflug [email protected] writes:

@thomasf indeed, such an option would be excellent. :)

+1 again :-)

Thank you @thomasf.

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

Ive pushed a change.. just set all plus/minus options to 1.0 and you should have no more scaling.

from solarized-emacs.

oscarfv avatar oscarfv commented on August 18, 2024

Thomas Frössman [email protected] writes:

Ive pushed a change.. just set all plus/minus options to 1.0 and you
should have no more scaling.

The change works as advertised, thanks!

However, org buffers still appear uneasy to the eye, IMO. Bold font
makes the headers text larger than normal, which in some sense defeats
the purpose of setting -plus-* to 1.0. Also, variable-pitch messes the
position of certain elements such as tags, which in fixed-pitch fonts
appear nicely aligned to the right.

IMHO the structure of Org files is clearly visualized with the sole help
of colors and indentation, i.e. 517fd96 is unnecesary and makes things
look worse.

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

i'll just add one more customization and remove bold...

from solarized-emacs.

thomasf avatar thomasf commented on August 18, 2024

done

from solarized-emacs.

mboes avatar mboes commented on August 18, 2024

Wow, thanks for the super quick fixes, @thomasf !

from solarized-emacs.

oscarfv avatar oscarfv commented on August 18, 2024

Thomas Frössman [email protected] writes:

done

Org files now look fine to me. Thanks for being so responsive Thomas.

However, the approach of customizing sizes and pitch for all modes might
not be optimal. I remember that using different font sizes made a lot of
sense while editing LaTex files.

I'm thinking on a customization scheme based on face groups. We'll use
solarized-org-height-plus-1, for instance. Its default value would be
solarized-height-plus-1, so it would be still posible to set that height
globally. The defcustoms could be auto generated by a macro.

I'll see if I have some spare time for making a patch.

from solarized-emacs.

imranmunshi avatar imranmunshi commented on August 18, 2024

I am getting this issue on emacs 25.2.1 on Arch Linux.
solarized-theme from melpa, disable scaling for org mode in solarized using customization, but no effect. Org-mode still displays proportional fonts.

from solarized-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.