Comments (4)
Hmm, I think it works as it should in 24.2.1, I just recompiled from the emacs24-branch.
from solarized-emacs.
Sorry, I'm actually using 24.2.1 binary from gnu.org on windows.
Curiously, zenburn comments that hl-line is for "old-emacsen", while solarized doesn't define it. I think moving from zenburn to solarized triggers this problem.
On a related note, solarized.el defines hl-line-face with solarized-bg, which is the normal background. I think it should be solarized-hl as with the highlight face.
from solarized-emacs.
Non of them are deprecated, hl-line is a (defface, added in 2006 according to the changelog. hl-line-face copies it so i belive you are right. I'll do that change.
hl-line.el
(defface hl-line
'((t :inherit highlight))
"Default face for highlighting the current line in Hl-Line mode."
:version "22.1"
:group 'hl-line)
(defcustom hl-line-face 'hl-line
"Face with which to highlight the current line in Hl-Line mode."
:type 'face
:group 'hl-line
:set (lambda (symbol value)
(set symbol value)
(dolist (buffer (buffer-list))
(with-current-buffer buffer
(when hl-line-overlay
(overlay-put hl-line-overlay 'face hl-line-face))))
(when global-hl-line-overlay
(overlay-put global-hl-line-overlay 'face hl-line-face))))
from solarized-emacs.
Thanks for spotting this.
from solarized-emacs.
Related Issues (20)
- is MELPA the only way to install solarized-emacs? HOT 1
- After `emacs -nw`, themes gets messed up on GUI Emacs HOT 2
- Bad visibility of swiper matches
- Seems like load-theme's NO-ENABLE parameter is ignored HOT 2
- Line number style changes depending on leading whitespace HOT 1
- remove Underline
- Next release / addition to NonGNU ELPA HOT 3
- Missing faces for tab-bar mode
- Link to bottomline/baseline image in README broken HOT 1
- Compilation of package fails in Emacs 28 due to change in define-function-obsolete-alias HOT 5
- Color not shown correctly on ssh HOT 3
- Dependency on dash not present in emacs package
- Solarized 1.3.0 package not compatible with dash 2.19.1? HOT 2
- Error: Wrong number of arguments: (3 . 4), 2 HOT 3
- There is no distance between the background color of fringe and default. HOT 1
- modeline bottom border wrong position HOT 2
- Markdown header scaling
- Invalid face box: :line-width, 4, :color, "grey90", :style, nil HOT 3
- Compilation warnings & other small issues HOT 2
- How do I add a theme for a new package?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from solarized-emacs.