Code Monkey home page Code Monkey logo

Comments (8)

piuccio avatar piuccio commented on August 22, 2024 3

@vagusX I haven't heard from @bazilio91 but I'm using https://github.com/piuccio/ejs-compiled-loader in production and works fine for me with webpack 4

npm i @piuccio/ejs-compiled-loader

from ejs-compiled-loader.

Adam-Meisen avatar Adam-Meisen commented on August 22, 2024 2

I might be able to help, but I'm a bit confused. The version installed from npm with npm install ejs-compiled-loader is version 1.1.0. That's also the version I got from running yarn add ejs-compiled-loader@latest. However, this repository defaults to the 2.x branch. Is that intentional? Is there a reason that npm doesn't default to the 2.x branch as well?

Second, I see the 2.2.0 version still uses the include path/to/file syntax from ejs 1.x, is that just because it hasn't been updated to the newer include('path/to/file', {options}) syntax, or is that a design decision?

from ejs-compiled-loader.

bazilio91 avatar bazilio91 commented on August 22, 2024

@Adam-Meisen there is nothing in this design we can't change. I'm looking to find some time now to setup travis or circle to automate releases for this repo and invite some more collabs. Are you still interested?

The version installed from npm with npm install ejs-compiled-loader is version 1.1.0

Looks like it is default behaviour when you do npm publish, no matter if it is 1.x or 2.x, the last one was 1.1.0

from ejs-compiled-loader.

ianwalter avatar ianwalter commented on August 22, 2024

I'm interested. I would like to set up CI to get #32 and #34 squared away.

from ejs-compiled-loader.

piuccio avatar piuccio commented on August 22, 2024

I'm also interested in contributing. I use this loader in my project and it's quite useful.

As a matter of facts I forked the repo already and implemented the changes needed to support webpack@4
It's here if you want to try it out. I haven't updated the README yet.

It's published on npm as @piccio/ejs-compiled-loader version 3.0.0.

If there's interest I can make a PR. @bazilio91 let me know

from ejs-compiled-loader.

vagusX avatar vagusX commented on August 22, 2024

so any new progress?

from ejs-compiled-loader.

bazilio91 avatar bazilio91 commented on August 22, 2024

@piuccio this repo is still getting lots of downloads, and I have some time now to get this solved, will u join this repo to maintain it with some other guys who is interested in it and maintaining own forks?

from ejs-compiled-loader.

piuccio avatar piuccio commented on August 22, 2024

from ejs-compiled-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.