duplicate repos between WORKSPACE and MODULE when using repo_name mapping about bazel HOT 5 OPEN

Slack context: https://bazelbuild.slack.com/archives/C014RARENH0/p1711483035156299?thread_ts=1711392090.732839&cid=C014RARENH0

from bazel.

Sorry for the long delay. In the README of your repro, you said:

This repository shows bazel_dep(name = "aspect_bazel_lib", version = "2.3.0", repo_name = "foobar") in MODULE.bazel NOT shadowing the aspect_bazel_lib loaded by rules_js via rules_js_dependencies() in WORKSPACE.

But that's expected behavior. This dep would shadow a repo called foobar loaded in WORKSPACE. If you remove the repo_name="foobar" part, it would correctly shadow anything called aspect_bazel_lib.

from bazel.

But that's expected behavior. This dep would shadow a repo called foobar loaded in WORKSPACE

That also does not work. See the protobuf example in the issue description.

from bazel.

But that's expected behavior. This dep would shadow a repo called foobar loaded in WORKSPACE

That also does not work. See the protobuf example in the issue description.

That would be unexpected. Do you have a repro for that?

from bazel.

There are various cases where shadowing is required. When legacy non-bzlmod loads a repository we need a reliable way to ensure that it can be shadowed by bzlmod modules.

1. http_archive(name) may need to be shadowed by bazel_dep(name), this seems to work
2. http_archive(name) may need to be shadowed by bazel_dep(repo_name), this seems broken
3. http_archive(name) may need to be shadowed by bazel_dep(name) while I want to use repo_name for my local repo

The first seems to work, the protobuf issue is 2, and I guess my repo showed 3.

I'll try adding a case for 2 in my repo but I'm having trouble creating a simple one, I've only had the issue in fairly large repos.

from bazel.