shell completion issue about basti HOT 6 CLOSED

adopted like that SHELL=zsh basti completion, and it fixed my issue. thanks!

from basti.

Hey @chenrui333, thank you for your work on the homebrew formula! ❤️

Basti uses the yargs library which doesn't expect any additional arguments for the completion command. So the following commands will return exactly the same output:

1. basti completion zsh
2. basti completion anything
3. basti completion

Can the supported basti completion command be used in brew instead of removing the recommendations?

from basti.

Can the supported basti completion command be used in brew instead of removing the recommendations?

it simply does not work, based on what I see, there is not much use of recommendCommands

from basti.

Just to clarify, do you mean that basti completion doesn't work or basti completion zsh doesn't work?

The value of the recommendCommands functionality is questionable indeed so if removing it will help in the Homebrew formula creation, we can do this.

from basti.

Just to clarify, do you mean that basti completion doesn't work or basti completion zsh doesn't work?

if you do SHELL=zsh basti completion zsh, that does not work.

And SHELL=zsh basti completion bash still outputs bash completion, which is wrong

The value of the recommendCommands functionality is questionable indeed so if removing it will help in the Homebrew formula creation, we can do this.

yeah, let's remove that, I dont see any values of it. People can either do help or just tldr to see the manual

from basti.

According to the yargs docs, the completion command doesn't expect any additional arguments. I can see that the output of the basti completion command changes according to the SHELL env variable:

1. SHELL=zsh basti completion - outputs completion for zsh
2. SHELL=bash basti completion - outputs completion for bash

Please, note the absence of any arguments after the completion command. Can the command be used without additional arguments like zsh or bash in Homebrew?

from basti.