Set Timeout in M/R about riak-dotnet-client HOT 7 CLOSED

Hello Tiago,

Thanks for the email! Yes I am afraid you are correct, we don't currently
have a configurable timeout for M/R specifically as you would see in the
HTTP API. The protocol buffers API doesn't provide a timeout value, so I
believe that this should instead be set as the "read" timeout on the socket.

In your configuration for your application, you can set a
networkReadTimeout which
tells the socket to wait longer before any response comes down. This
might be what you're looking for?

Unfortunately this value is set per-node in the cluster, which isn't
exactly flexible. One of the features that I aim to get done is to allow
this value to be set on the socket for each request that is made, as this
would allow the callers to have control over the timeout rather than having
it set across all calls on that node.

Would it be possible for you to see if changing this value helps you in the
short term?

If you are interested in helping out in any way we would greatly appreciate
it. But don't feel pressured :) I am happy to look into exposing the
timeout value per-request in the next few days.

Thank you again for your email! It's great to hear from another CI user.

Best regards
OJ

from riak-dotnet-client.

Hello OJ

Thanks for your reply. Initially, I set the networkReadTimeout value in the node configuration section of my riak config file. The problem is that this timeout does not apply to the M/R query...

I think the timeout property they talk about ("Map/Reduce queries have a default timeout of 60000 milliseconds (60 seconds). The default timeout can be overridden by supplying a different value, in milliseconds, in the JSON document:") can be applied for both HTTP and Protocol Buffer interfaces because it is part of the JSON object that is sent to the server.

In the context of CorrugatedIron and as an example, you would only need to add a public property in the RiakMapReduceQuery class and then add an extra step in the Compile() function in order to serialize the timeout as well (using the JsonWriter).

Best regards
Tiago

from riak-dotnet-client.

Tiago,

You are indeed correct! How silly of me. This should be a very simple thing to fix and it looks like you've already got across what needs to be done.

If you're interested in helping out we would love to receive a pull request from you. If you don't have the time I am happy to look into this tonight.

Thanks again Tiago,

Best regards
OJ

from riak-dotnet-client.

OJ, no problem! Glad I could help.

I've already wrote the fix and a corresponding unit test. Let me get my head around this github thing since this is my first fork :)

Best regards
Tiago

from riak-dotnet-client.

Tiago,

Wonderful! Thanks very much. I look forward to seeing your pull request. There are stacks of great documents on how to work with github for this sort of thing.

Cheers mate,
OJ

from riak-dotnet-client.

You're welcome! I've sent a pull request and I'm closing this issue now :)

from riak-dotnet-client.

I'll close the issue when I merge the request mate.

Cheers!
On Aug 22, 2012 6:41 PM, "Tiago Margalho" [email protected] wrote:

You're welcome! I've sent a pull request and I'm closing this issue now :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-7927970.

from riak-dotnet-client.