Implement GetObject<T> and SetObject<T> with custom SerDe about riak-dotnet-client HOT 5 CLOSED

This should be able to use DataContractSerializer which will move the onus of responsibility to programmers who want to use CorrugatedIron. On the bright side: it'll work. Otherwise, everyone will be filled with rage because their code is now full of decorators and attributes and horrible line noise.

from riak-dotnet-client.

You guys might want to look a look at what Demis has already done in ServiceStack.Text... he built this for a few different needs -- serialization over a REST service layer, serialization to Redis (where he uses his Json serializer) and for his OrmLite. I know you're already using Json.net, but there are advantages to using his library, including a set of helpers over DataContractSerializer [1] that might make your life easier when supporting Xml. He also supports some other formats, though for Riak, if you want to use search, Json and Xml are the way to go.

The code is pretty modular and ready to go:
https://github.com/ServiceStack/ServiceStack.Text

Just letting you know about it as an option in case you haven't seen it.

[1] https://github.com/ServiceStack/ServiceStack.Text/blob/master/src/ServiceStack.Text/XmlSerializer.cs

from riak-dotnet-client.

Thanks for the heads up. That might be a lot easier to implement and maintain in the long run. Right now I suspect that our XML support in v0.1.2 requires fully loading the XML document into memory before doing any magic. This won't work well for larger objects.

I know that JSON.NET falls down, performance wise, around a certain document size. That's always been a concern of ours as well, but we were going to leave that until we encountered it in the wild.

I'll clear out a few tasks and spike some changes with this to see what kind of changes it makes for performance.

from riak-dotnet-client.

Great suggestion Iristyle, thanks for that! JP and I will look into this and see how best to incorporate it.

from riak-dotnet-client.

Implemented a fix for this in commit c6d55b4

from riak-dotnet-client.