Where is the tag for 1.2.8? about base62.js HOT 11 CLOSED

I have no idea 😂

from base62.js.

Done: https://github.com/andrew/base62.js/commits/v1.2.8

Hope that helps, @willdurand.

from base62.js.

That would have to be 4fc9daf, as that's the only commit between v1.2.7 and when I started contributing towards v2.0.0 - but I'll leave it to @andrew to confirm that.

from base62.js.

I’d recommend using 2.X

from base62.js.

I have no idea 😂

oh, heh.

I’d recommend using 2.X

Yep, but our test suite fails when upgrading from 1.2.8 to 2.0.0 (using the legacy API). It seem an invalid data to decode does not throw any error anymore and we get NaN instead. I am not sure though.

from base62.js.

Maybe it's worth changing the title of the issue to report that bug instead?

from base62.js.

I'll report the bug once I'll have a test case, in another issue. This issue is valid though, it'd be nice to have tags for each npm release.

from base62.js.

Thank you, @willdurand. Perhaps this is also related to #57 (though the behavior shouldn't have changed in that regard).

from base62.js.

@willdurand as I mentioned before, I don't know where to put that tag as it was a long time ago.

from base62.js.

@andrew: I've just checked against the contents of the npm package and I'm fairly certain that the commit I'd identified above was in fact v1.2.8 - do you mind if I create that tag retroactively?

from base62.js.

@FND sure

from base62.js.