External monitor connect/disconnect Actions are triggered accidentally when Lid opened/closed about lenovolegiontoolkit HOT 7 CLOSED

It's also really tricky to me. This bug happened all the time two weeks ago, but I cannot reproduce it any more either. Logs are checked, pipelines aren't triggered (monitor connected msg isn't received).

log_2024_05_13_06_08_17.txt

I wondered if it's a bug from ms and was fixed in the past two weeks, but my laptop didn't install any updates except ms defender antivirus during this time. I'll still try the new test build and tell u what's going on anyway.

from lenovolegiontoolkit.

It might have been a fluke, to be honest. Internal display is technically never disconnected, so it is a bit odd.

from lenovolegiontoolkit.

Yup just pushed a change - there was a typo.

from lenovolegiontoolkit.

After giving this a thought, I think I will just go ahead and merge the PR. It doesn't really break anything and might add some more accuracy, that won't hurt.

from lenovolegiontoolkit.

This seems to be a tricky one, here is a workaround for this: installer

It's hard for me to test it though, since it seems that this behavior isn't present on my machine. Let me know if this works better.

from lenovolegiontoolkit.

log_2024_05_13_19_13_22.txt

It seems that both connecting and disconnecting external monitor trigger the external monitor connected automation pipe. I compiled a build from branch bug/external-screen-action myself since new commit was made, this bug remains.

Here is also a low caught with the latest build on branch bug/external-screen-action which also tested this bug: log_2024_05_13_19_22_44.txt

log_2024_05_13_19_24_27.txt

Lid opening and closing look fine.

And btw, as the second log file shows, external monitor (dis)connected on startup works pretty fine, the bug which is described above only appears after startup.

from lenovolegiontoolkit.

Just checked, looks good up till now

from lenovolegiontoolkit.