Code Monkey home page Code Monkey logo

Comments (5)

barrust avatar barrust commented on June 15, 2024

pymediawiki currently sets the browser user-agent string (user_agent) which allows up to follow the guidelines. It does default to signal that it is this library using the infrastructure but a user can change it to something else, if necessary.

from mediawiki.

inktrap avatar inktrap commented on June 15, 2024

Yes, but shouldn't the custom user agent be (a) an explicit setting/parameter and (b) be present in the examples? To quote from the docs above (emphasis mine):

Don't use the default User-Agent provided by your client library, but make up a custom header that identifies your script or service and provides some type of means of contacting you (e.g., an e-mail address).

I mean, shouldn't it be as easy as possible for the user to do this?

from mediawiki.

barrust avatar barrust commented on June 15, 2024

I didn't notice that language in the etiquette. Good catch! Do you think adding a user_agent parameter to the initialization would be sufficient? I can also add it to some of the documentation also.

from mediawiki.

barrust avatar barrust commented on June 15, 2024

Resolved by PR #53

Added initialization parameter and added documentation about setting the user-agent string. Thank you again for pointing this out!

from mediawiki.

barrust avatar barrust commented on June 15, 2024

Added to release 0.4.1 and uploaded it to pypi

from mediawiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.