failure to raise DisambiguationError for "Leaching" page on Wikipedia about mediawiki HOT 7 CLOSED

Great catch, I hadn't looked at the title portion in awhile. Would you like to open a new issue so that we can track this? Thanks!

from mediawiki.

@lebedov Thank you for reporting this issue. I hope that pymediawiki has been a useful library.

The issue, upon a cursory look, seems to stem from the parsing of disambiguation details. I have a fix that I am working on and hope to push to pypi later today or over the holidays.

from mediawiki.

@lebedov : this should be resolved in version 0.3.16. You can get the latest using pip:

pip install pymediawiki --upgrade

Please let me know how the pymediawiki is working for you and if you run into any other issues!

from mediawiki.

Looks good. Thanks for the quick fix!

from mediawiki.

Hi, thanks for all your work on this project! It has been very handy.

I think there might still be a small bug associated with this issue/associated PR.

243e7a0#diff-c017063330dbc8ad5b88a8c5049c389bR568

Following the link above to the code raising a DisambiguationError, I think the new line if item and hasattr(item, 'title'): will always evaluate to False because item is what's returned by a beautifulsoup find_all() call, which is a list. Should it be if item and hasattr(item[0], 'title'): instead?

This led to some confusion on my end, because I've been always seeing the disambiguation['title'] equal the full text of the li rather than just the title of the link...

from mediawiki.

@awbirdsall can you provide me an example where this is not working correctly? For the pages that I am testing I am seeing what I expected to see. Thanks!

from mediawiki.

@barrust : here's an example for "Lincoln Museum" (https://en.wikipedia.org/wiki/Lincoln_Museum):

from mediawiki import MediaWiki, DisambiguationError
wikipedia = MediaWiki()

try:
    p = wikipedia.page("Lincoln Museum")
except DisambiguationError as d:
    print(d.details[5]['title'])
    print(d.details[5]['description'])

I'd expect the title here to be only "Ford's Theatre" since that's the title of the link, but instead the title is the same as the full description (both are Ford's Theatre, Washington, DC, USA — where Abraham Lincoln was assassinated; known as Lincoln Museum from 1936 to 1965 and legally "Ford's Theater (Lincoln Museum)" since 1965).

In [8]: print(mediawiki.__version__)                                                                               
0.6.0

from mediawiki.