Code Monkey home page Code Monkey logo

Comments (2)

tyarkoni avatar tyarkoni commented on May 30, 2024

I added an explicit prior argument in add_y.

I didn't modify set_y at all, but I'm leaning towards removing it entirely; I think it's a bit confusing to have both add_y and set_y. It seems reasonable to expect users to know in advance of model specification which variable is going to be the outcome, and since the overhead of setting up a model is now much lower than before (since nothing gets compiled until build() or fit() are called), I don't know that there's a need for a set_y call anyway. Any objections?

from bambi.

jake-westfall avatar jake-westfall commented on May 30, 2024

I agree about it being confusing to have both add_y and set_y, I had the same thought while going through the code.

from bambi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.