Code Monkey home page Code Monkey logo

Comments (8)

badlogic avatar badlogic commented on August 16, 2024

Spar units are kind of fucked for some products. Should be 250ml, is 200ml.
Screenshot 2023-05-31 at 17 08 48

from heissepreise.

mhochsteger avatar mhochsteger commented on August 16, 2024

See #49 for fixing the spar units.

Concerning the hard-coded 100g base price: Does it make sense to switch from price/100g to price/kg below a certain price (like 50Cent/100g)?
Alternative: let the user select the base unit

from heissepreise.

badlogic avatar badlogic commented on August 16, 2024

I think the latest changes are good enough.

from heissepreise.

badlogic avatar badlogic commented on August 16, 2024

mpreis weighted items are still wonky. E.g.

https://heisse-preise.io/?q=!isWeighted%3Dtrue%20and%20%60store%60%3D%22mpreis%22

Example:
Screenshot 2023-06-05 at 21 46 02

quantity is 900g, but the price is the kilo price.
https://www.mpreis.at/shop/p/zuckerhut-salat-ca-1-stueck-541201

Haven't dug into mpreis at all yet.

from heissepreise.

badlogic avatar badlogic commented on August 16, 2024
Screenshot 2023-06-05 at 22 12 23

Bunch of Spar items are super wonky on their end. Unit then defaults to 1 stk, while they are weighted.

from heissepreise.

badlogic avatar badlogic commented on August 16, 2024

Spar also has "supposed" weighted items:
https://www.interspar.at/shop/lebensmittel/spar-naturpur-bio-apfel-gala-per-tasse/p/6725006

We give the per kg price, while they are only sold in increments of 900g. Not sure how to handle this case.

from heissepreise.

mhochsteger avatar mhochsteger commented on August 16, 2024

Concerning MPREIS Zuckerhut, the raw data looks like this (which is inconsistent in my opinion):

        "originalAmount": 1.791,
        "effectiveAmount": 1.791,
        "measurementUnit": {
          "quantity": 1,
          "unitCode": "GRM"
        },
        "basePrice": {
          "originalAmount": 1.99,
          "effectiveAmount": 1.99,
          "measurementUnit": {
            "quantity": 1,
            "unitCode": "KGM"
          }
        },
        "presentationPrice": {
          "originalAmount": 1.99,
          "effectiveAmount": 1.99,
          "measurementUnit": {
            "quantity": 900,
            "unitCode": "GRM"
          }
        },

from heissepreise.

badlogic avatar badlogic commented on August 16, 2024

Yeah, they are loosey goosey with the unit/quantity/price data. Ah well, another day :)

from heissepreise.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.