[Issue]A double free bug in ulfius.c about ulfius HOT 4 CLOSED

Thanks,

this should be fixed in e458353 , can you check it again?

from ulfius.

Hi, thanks for your reply!
But I think it has not been fixed completely, maybe I didn't explain the issue clearly, sorry for that : )

What I think of the issue is:
At line 1689 in ulfius.c, u_map_init(u_instance->default_headers); will be called, in this function, u_instance->default_headers->keys might be freed [u_map.c, line 45].

Then, at line 1701 in ulfius.c, there is a possibility thatulfius_clean_instance(u_instance); will be called. This function, it will execute this trace:

u_map_clean_full(u_instance->default_headers)            [ulfius.c, line 1627] -> 
u_map_clean(u_map)                                       [u_map.c, line 82] -> 
o_free(u_map->keys)                                      [u_map.c, line 72]

In this case, u_instance->default_headers->keys will be freed again. May be it can be fixed by checking if u_map->keys == NULL before [u_map.c, line 72].

Have a good day~

from ulfius.

OK, I think I see now, I've added some u_map->keys = NULL; and al. in the functions u_map_clean and u_map_init in the last commit 0d4f7ab , can you verify it again please?

from ulfius.

I think it is fine now, so I'll close this issue, thanks for your cooperation!

from ulfius.